Map control bar: fold the toggles in, and stop autofill over the frequency #40

Merged

sjg merged 2 commits from fix/map-control-bar into main 2026-08-05 20:19:55 +02:00

Conversation 0 Commits 2 Files Changed 6

+133 -76

sjg commented 2026-08-05 19:37:05 +02:00

Owner

Copy Link

Copy Source

Closes both open map issues, one commit each, on top of the filter-bar rework they build on.

Map filters as a bar (08005c5)

The filters were a 30rem column parked bottom-right, covering about a third of the map. They are now a horizontal bar across the top — label beside control, thin rules between — one row at 1600px, wrapping as the window narrows. It starts clear of Leaflet's zoom buttons and leaves the bottom-left band legend alone. The sentence explaining the two path toggles moved to their tooltips, and is still shown inline in the stacked narrow-screen layout.

#38 — fullscreen/hide filters into the control bar (88d0425)

Both controls now sit at the right-hand end of the bar, behind a separator. The snag was that Hide Filters cannot live inside the thing it hides, so the collapse applies to the filters alone: the bar keeps its two buttons and shrinks to them at the map's right edge, leaving the whole map visible and the way back one click away.

#39 — saved entries over the frequency input (90ab778)

#freq and #center-freq are text inputs, so the browser remembers what has been typed into them and offers it back over the reading. Both now carry autocomplete="off" (plus autocorrect/spellcheck off).

Worth knowing: I could not reproduce or verify this one in Edge from here — the browser suite runs Chromium. autocomplete="off" is the standard fix and the test asserts the attribute is present, but confirmation that Edge's dropdown is actually gone needs a look on your side.

Tests

spectrum-layout.mjs gained a map-layout block: at 1600 and 1200 the bar covers ≥70% of the map, stays ≤140px tall, does not run off the stage or overlap the zoom control or legend, is not clipping itself, carries both action buttons, and — after Hide Filters — collapses to under 30% at the right edge with its own toggle still clickable, then restores. browser-smoke.mjs asserts autofill is off on both frequency fields. Both verified to fail without their fix.

Green: 3 browser suites, lint, typecheck, 55 crate tests.

Closes both open map issues, one commit each, on top of the filter-bar rework they build on. ### Map filters as a bar (`08005c5`) The filters were a 30rem column parked bottom-right, covering about a third of the map. They are now a horizontal bar across the top — label beside control, thin rules between — one row at 1600px, wrapping as the window narrows. It starts clear of Leaflet's zoom buttons and leaves the bottom-left band legend alone. The sentence explaining the two path toggles moved to their tooltips, and is still shown inline in the stacked narrow-screen layout. ### #38 — fullscreen/hide filters into the control bar (`88d0425`) Both controls now sit at the right-hand end of the bar, behind a separator. The snag was that Hide Filters cannot live inside the thing it hides, so the collapse applies to the filters alone: the bar keeps its two buttons and shrinks to them at the map's right edge, leaving the whole map visible and the way back one click away. ### #39 — saved entries over the frequency input (`90ab778`) `#freq` and `#center-freq` are text inputs, so the browser remembers what has been typed into them and offers it back over the reading. Both now carry `autocomplete="off"` (plus `autocorrect`/`spellcheck` off). **Worth knowing:** I could not reproduce or verify this one in Edge from here — the browser suite runs Chromium. `autocomplete="off"` is the standard fix and the test asserts the attribute is present, but confirmation that Edge's dropdown is actually gone needs a look on your side. ### Tests `spectrum-layout.mjs` gained a map-layout block: at 1600 and 1200 the bar covers ≥70% of the map, stays ≤140px tall, does not run off the stage or overlap the zoom control or legend, is not clipping itself, carries both action buttons, and — after Hide Filters — collapses to under 30% at the right edge with its own toggle still clickable, then restores. `browser-smoke.mjs` asserts autofill is off on both frequency fields. Both verified to fail without their fix. Green: 3 browser suites, lint, typecheck, 55 crate tests.

sjg added 2 commits 2026-08-05 19:37:05 +02:00

[fix](trx-frontend-http): move the map's fullscreen and filter toggles into the bar ... 88d04253ca

Fullscreen and Hide Filters floated in their own block over the map's
top-right corner, separate from the filter bar they sit beside.

Put them at the right-hand end of the bar, behind a separator. What made
this awkward before is that Hide Filters cannot live inside the thing it
hides, so the collapse now applies to the filters alone: the bar keeps its
two controls and shrinks to them at the map's right edge, leaving the whole
map visible and the way back one click away.

Fixes #38

Signed-off-by: Stan Grams <sjg@haxx.space>

[fix](trx-frontend-http): stop the browser offering saved values for frequency ... 90ab7781ad

The tuned and centre frequency readouts are text inputs, so the browser
keeps what has been typed into them and offers it back in a dropdown --
Edge does this out of the box, dropping stale frequencies from other
sessions over the reading.

Turn autofill off on both, along with autocorrect and spellcheck, which
have no business near a number either.

Fixes #39

Signed-off-by: Stan Grams <sjg@haxx.space>

sjg merged commit 90ab7781ad into main 2026-08-05 20:19:55 +02:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something is not working

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

wontfix

This won't be fixed

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

sjg (Stan Grams)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sjg/trx-rs#40