sjg/trx-rs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make the Guest role composable #66

Merged
sjg merged 1 commits from agent/composable-guest-role into main 2026-08-13 02:20:58 +02:00
Conversation 0 Commits 1 Files Changed 4
+33 -13
sjg commented 2026-08-13 02:17:13 +02:00
Owner
Copy Link
Copy Source

Summary

  • allow Guest to combine with Read, Control, Transmit, and Write
  • keep Guest incompatible with Administrator
  • preserve the Guest restriction on password changes and account controls
  • update role-picker behavior and browser regression coverage
  • regenerate the committed frontend bundle

Why

The role picker treated Guest as mutually exclusive with every other role. Selecting an operational permission therefore removed Guest and unintentionally removed its password/account restriction. Guest is better modeled as an account-policy flag that can accompany ordinary radio permissions.

Impact

Guest users can receive additional operating permissions without gaining password or account controls. Selecting Guest only clears Administrator; selecting Administrator clears Guest.

Validation

  • npm run typecheck
  • npm run lint
  • npm test (64 passed)
  • npm run build
  • cargo fmt --all -- --check
  • cargo test -p trx-frontend-http auth::tests --lib (18 passed)
  • node tests/account-management.mjs with installed Chrome
## Summary - allow Guest to combine with Read, Control, Transmit, and Write - keep Guest incompatible with Administrator - preserve the Guest restriction on password changes and account controls - update role-picker behavior and browser regression coverage - regenerate the committed frontend bundle ## Why The role picker treated Guest as mutually exclusive with every other role. Selecting an operational permission therefore removed Guest and unintentionally removed its password/account restriction. Guest is better modeled as an account-policy flag that can accompany ordinary radio permissions. ## Impact Guest users can receive additional operating permissions without gaining password or account controls. Selecting Guest only clears Administrator; selecting Administrator clears Guest. ## Validation - `npm run typecheck` - `npm run lint` - `npm test` (64 passed) - `npm run build` - `cargo fmt --all -- --check` - `cargo test -p trx-frontend-http auth::tests --lib` (18 passed) - `node tests/account-management.mjs` with installed Chrome
sjg added 1 commit 2026-08-13 02:17:13 +02:00
[fix](trx-frontend-http): make Guest role composable
CI / lint (pull_request) Successful in 2m25s
Details
CI / test (pull_request) Successful in 9m16s
Details
CI / frontend (pull_request) Successful in 5m22s
Details
CI / reuse (pull_request) Successful in 6s
Details
CI / lint (push) Successful in 2m23s
Details
CI / test (push) Successful in 8m11s
Details
CI / frontend (push) Successful in 4m24s
Details
CI / reuse (push) Successful in 4s
Details
1829e3d17b
sjg marked the pull request as ready for review 2026-08-13 02:20:48 +02:00
sjg merged commit 1829e3d17b into main 2026-08-13 02:20:58 +02:00
sjg deleted branch agent/composable-guest-role 2026-08-13 02:20:58 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
sjg (Stan Grams)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sjg/trx-rs#66