[fix](trx-frontend-http): stop doubling the space under the Statistics title #31

Merged

sjg merged 1 commits from fix/statistics-title-spacing into main 2026-08-02 23:51:03 +02:00

Conversation 0 Commits 1 Files Changed 1

+7 -1

sjg commented 2026-08-02 23:50:04 +02:00

Owner

Copy Link

Copy Source

The offset

The page titles carry margin-bottom: var(--space-3), which is what spaces them from the content on the plain block panels — Recorder, Settings and About.

#tab-statistics is not one of those. It is a flex column with gap: 1rem, so the margin landed on top of that gap:

before   statistics 28px   recorder 12px   settings 12px   about 12px
after    statistics 16px   recorder 12px   settings 12px   about 12px

Dropping the margin on that panel lets its own gap do the spacing.

On the remaining 16 vs 12

Statistics settles at 16px rather than 12px because that is its panel gap, which every other child of that panel is spaced by. Forcing it to 12px would need a negative margin fighting the container. Matching the page's own rhythm is the better answer than matching a number across pages that lay out differently.

Full gate green — lint, 34/34 test, build, test:browser.

🤖 Generated with Claude Code

https://claude.ai/code/session_01GdyUjuXejCEfiub675z6cz

## The offset The page titles carry `margin-bottom: var(--space-3)`, which is what spaces them from the content on the plain block panels — Recorder, Settings and About. `#tab-statistics` is not one of those. It is a flex column with `gap: 1rem`, so the margin landed **on top of** that gap: ``` before statistics 28px recorder 12px settings 12px about 12px after statistics 16px recorder 12px settings 12px about 12px ``` Dropping the margin on that panel lets its own `gap` do the spacing. ## On the remaining 16 vs 12 Statistics settles at 16px rather than 12px because that is its panel gap, which every other child of that panel is spaced by. Forcing it to 12px would need a negative margin fighting the container. Matching the page's own rhythm is the better answer than matching a number across pages that lay out differently. Full gate green — `lint`, 34/34 `test`, `build`, `test:browser`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01GdyUjuXejCEfiub675z6cz

sjg added 1 commit 2026-08-02 23:50:04 +02:00

[fix](trx-frontend-http): stop doubling the space under the Statistics title ... 5ad91b4ab6

The page titles carry a bottom margin, which is what spaces them from the
content on the plain block panels.  #tab-statistics is not one: it is a
flex column with `gap: 1rem`, so the margin landed on top of that gap and
left 28px under the title where every other page had 12px.

Drop the margin on that panel and let its own gap do the spacing.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GdyUjuXejCEfiub675z6cz
Signed-off-by: Stan Grams <sjg@haxx.space>

sjg merged commit 5ad91b4ab6 into main 2026-08-02 23:51:03 +02:00

sjg referenced this pull request 2026-08-03 00:08:09 +02:00

[fix](trx-frontend-http): serve /statistics and /bookmarks, align the Statistics page #32

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something is not working

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

wontfix

This won't be fixed

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

sjg (Stan Grams)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sjg/trx-rs#31