[refactor](trx-server): supervise runtime tasks and shutdown

Add coordinated shutdown signaling and task supervision for long-running server and client tasks to avoid detached runtimes on Ctrl+C.

Co-authored-by: OpenAI Codex <codex@openai.com>
Signed-off-by: Stanislaw Grams <stanislawgrams@gmail.com>
This commit is contained in:
2026-02-12 21:49:39 +01:00
parent 6ce1b5be9d
commit cadb60f99d
7 changed files with 356 additions and 103 deletions
+48 -7
View File
@@ -15,9 +15,8 @@ use tokio::time;
use tracing::{info, warn}; use tracing::{info, warn};
use trx_core::audio::{ use trx_core::audio::{
read_audio_msg, write_audio_msg, AudioStreamInfo, AUDIO_MSG_APRS_DECODE, read_audio_msg, write_audio_msg, AudioStreamInfo, AUDIO_MSG_APRS_DECODE, AUDIO_MSG_CW_DECODE,
AUDIO_MSG_CW_DECODE, AUDIO_MSG_FT8_DECODE, AUDIO_MSG_RX_FRAME, AUDIO_MSG_STREAM_INFO, AUDIO_MSG_FT8_DECODE, AUDIO_MSG_RX_FRAME, AUDIO_MSG_STREAM_INFO, AUDIO_MSG_TX_FRAME,
AUDIO_MSG_TX_FRAME,
}; };
use trx_core::decode::DecodedMessage; use trx_core::decode::DecodedMessage;
@@ -28,16 +27,29 @@ pub async fn run_audio_client(
mut tx_rx: mpsc::Receiver<Bytes>, mut tx_rx: mpsc::Receiver<Bytes>,
stream_info_tx: watch::Sender<Option<AudioStreamInfo>>, stream_info_tx: watch::Sender<Option<AudioStreamInfo>>,
decode_tx: broadcast::Sender<DecodedMessage>, decode_tx: broadcast::Sender<DecodedMessage>,
mut shutdown_rx: watch::Receiver<bool>,
) { ) {
let mut reconnect_delay = Duration::from_secs(1); let mut reconnect_delay = Duration::from_secs(1);
loop { loop {
if *shutdown_rx.borrow() {
info!("Audio client shutting down");
return;
}
info!("Audio client: connecting to {}", server_addr); info!("Audio client: connecting to {}", server_addr);
match TcpStream::connect(&server_addr).await { match TcpStream::connect(&server_addr).await {
Ok(stream) => { Ok(stream) => {
reconnect_delay = Duration::from_secs(1); reconnect_delay = Duration::from_secs(1);
if let Err(e) = if let Err(e) = handle_audio_connection(
handle_audio_connection(stream, &rx_tx, &mut tx_rx, &stream_info_tx, &decode_tx).await stream,
&rx_tx,
&mut tx_rx,
&stream_info_tx,
&decode_tx,
&mut shutdown_rx,
)
.await
{ {
warn!("Audio connection dropped: {}", e); warn!("Audio connection dropped: {}", e);
} }
@@ -48,7 +60,19 @@ pub async fn run_audio_client(
} }
let _ = stream_info_tx.send(None); let _ = stream_info_tx.send(None);
time::sleep(reconnect_delay).await; tokio::select! {
_ = time::sleep(reconnect_delay) => {}
changed = shutdown_rx.changed() => {
match changed {
Ok(()) if *shutdown_rx.borrow() => {
info!("Audio client shutting down");
return;
}
Ok(()) => {}
Err(_) => return,
}
}
}
reconnect_delay = (reconnect_delay * 2).min(Duration::from_secs(10)); reconnect_delay = (reconnect_delay * 2).min(Duration::from_secs(10));
} }
} }
@@ -59,6 +83,7 @@ async fn handle_audio_connection(
tx_rx: &mut mpsc::Receiver<Bytes>, tx_rx: &mut mpsc::Receiver<Bytes>,
stream_info_tx: &watch::Sender<Option<AudioStreamInfo>>, stream_info_tx: &watch::Sender<Option<AudioStreamInfo>>,
decode_tx: &broadcast::Sender<DecodedMessage>, decode_tx: &broadcast::Sender<DecodedMessage>,
shutdown_rx: &mut watch::Receiver<bool>,
) -> std::io::Result<()> { ) -> std::io::Result<()> {
let (reader, writer) = stream.into_split(); let (reader, writer) = stream.into_split();
let mut reader = BufReader::new(reader); let mut reader = BufReader::new(reader);
@@ -89,7 +114,10 @@ async fn handle_audio_connection(
Ok((AUDIO_MSG_RX_FRAME, payload)) => { Ok((AUDIO_MSG_RX_FRAME, payload)) => {
let _ = rx_tx.send(Bytes::from(payload)); let _ = rx_tx.send(Bytes::from(payload));
} }
Ok((AUDIO_MSG_APRS_DECODE | AUDIO_MSG_CW_DECODE | AUDIO_MSG_FT8_DECODE, payload)) => { Ok((
AUDIO_MSG_APRS_DECODE | AUDIO_MSG_CW_DECODE | AUDIO_MSG_FT8_DECODE,
payload,
)) => {
if let Ok(msg) = serde_json::from_slice::<DecodedMessage>(&payload) { if let Ok(msg) = serde_json::from_slice::<DecodedMessage>(&payload) {
let _ = decode_tx.send(msg); let _ = decode_tx.send(msg);
} }
@@ -105,6 +133,19 @@ async fn handle_audio_connection(
// Forward TX frames to server // Forward TX frames to server
loop { loop {
tokio::select! { tokio::select! {
changed = shutdown_rx.changed() => {
match changed {
Ok(()) if *shutdown_rx.borrow() => {
rx_handle.abort();
return Ok(());
}
Ok(()) => {}
Err(_) => {
rx_handle.abort();
return Ok(());
}
}
}
packet = tx_rx.recv() => { packet = tx_rx.recv() => {
match packet { match packet {
Some(data) => { Some(data) => {
+49 -24
View File
@@ -14,16 +14,19 @@ use bytes::Bytes;
use clap::Parser; use clap::Parser;
use tokio::signal; use tokio::signal;
use tokio::sync::{broadcast, mpsc, watch}; use tokio::sync::{broadcast, mpsc, watch};
use tracing::info; use tokio::task::JoinHandle;
use tracing::{error, info};
use trx_app::{init_logging, load_plugins, normalize_name}; use trx_app::{init_logging, load_plugins, normalize_name};
use trx_core::audio::AudioStreamInfo; use trx_core::audio::AudioStreamInfo;
use trx_core::decode::DecodedMessage;
use trx_core::rig::request::RigRequest; use trx_core::rig::request::RigRequest;
use trx_core::rig::state::RigState; use trx_core::rig::state::RigState;
use trx_core::DynResult; use trx_core::DynResult;
use trx_frontend::{snapshot_bootstrap_context, FrontendRegistrationContext, FrontendRuntimeContext}; use trx_frontend::{
use trx_core::decode::DecodedMessage; snapshot_bootstrap_context, FrontendRegistrationContext, FrontendRuntimeContext,
};
use trx_frontend_http::register_frontend_on as register_http_frontend; use trx_frontend_http::register_frontend_on as register_http_frontend;
use trx_frontend_http_json::register_frontend_on as register_http_json_frontend; use trx_frontend_http_json::register_frontend_on as register_http_json_frontend;
use trx_frontend_rigctl::register_frontend_on as register_rigctl_frontend; use trx_frontend_rigctl::register_frontend_on as register_rigctl_frontend;
@@ -81,20 +84,33 @@ struct Cli {
callsign: Option<String>, callsign: Option<String>,
} }
fn main() -> DynResult<()> { #[tokio::main]
let rt = tokio::runtime::Runtime::new()?; async fn main() -> DynResult<()> {
let app_state = async_init().await?;
signal::ctrl_c().await?;
info!("Ctrl+C received, shutting down");
let _app_state = rt.block_on(async_init())?; let _ = app_state.shutdown_tx.send(true);
drop(app_state.request_tx);
tokio::time::sleep(Duration::from_millis(400)).await;
rt.block_on(async { for handle in &app_state.task_handles {
signal::ctrl_c().await?; if !handle.is_finished() {
info!("Ctrl+C received, shutting down"); handle.abort();
Ok(()) }
}) }
for handle in app_state.task_handles {
let _ = handle.await;
}
Ok(())
} }
/// Holds the state needed after async initialization completes. /// Holds the state needed after async initialization completes.
struct AppState; struct AppState {
shutdown_tx: watch::Sender<bool>,
task_handles: Vec<JoinHandle<()>>,
request_tx: mpsc::Sender<RigRequest>,
}
async fn async_init() -> DynResult<AppState> { async fn async_init() -> DynResult<AppState> {
use std::sync::Arc; use std::sync::Arc;
@@ -151,14 +167,9 @@ async fn async_init() -> DynResult<AppState> {
let remote_addr = let remote_addr =
parse_remote_url(&remote_url).map_err(|e| format!("Invalid remote URL: {}", e))?; parse_remote_url(&remote_url).map_err(|e| format!("Invalid remote URL: {}", e))?;
let remote_token = cli let remote_token = cli.token.clone().or_else(|| cfg.remote.auth.token.clone());
.token
.clone()
.or_else(|| cfg.remote.auth.token.clone());
let poll_interval_ms = cli let poll_interval_ms = cli.poll_interval_ms.unwrap_or(cfg.remote.poll_interval_ms);
.poll_interval_ms
.unwrap_or(cfg.remote.poll_interval_ms);
// Resolve frontends: CLI > config > default to http // Resolve frontends: CLI > config > default to http
let frontends: Vec<String> = if let Some(ref fes) = cli.frontends { let frontends: Vec<String> = if let Some(ref fes) = cli.frontends {
@@ -210,6 +221,8 @@ async fn async_init() -> DynResult<AppState> {
); );
let (tx, rx) = mpsc::channel::<RigRequest>(RIG_TASK_CHANNEL_BUFFER); let (tx, rx) = mpsc::channel::<RigRequest>(RIG_TASK_CHANNEL_BUFFER);
let (shutdown_tx, shutdown_rx) = watch::channel(false);
let mut task_handles: Vec<JoinHandle<()>> = Vec::new();
let initial_state = RigState::new_uninitialized(); let initial_state = RigState::new_uninitialized();
let (state_tx, state_rx) = watch::channel(initial_state); let (state_tx, state_rx) = watch::channel(initial_state);
@@ -226,8 +239,14 @@ async fn async_init() -> DynResult<AppState> {
token: remote_token, token: remote_token,
poll_interval: Duration::from_millis(poll_interval_ms), poll_interval: Duration::from_millis(poll_interval_ms),
}; };
let _remote_handle = let remote_shutdown_rx = shutdown_rx.clone();
tokio::spawn(remote_client::run_remote_client(remote_cfg, rx, state_tx)); task_handles.push(tokio::spawn(async move {
if let Err(e) =
remote_client::run_remote_client(remote_cfg, rx, state_tx, remote_shutdown_rx).await
{
error!("Remote client error: {}", e);
}
}));
// Audio streaming setup // Audio streaming setup
if cfg.frontends.audio.enabled { if cfg.frontends.audio.enabled {
@@ -248,13 +267,15 @@ async fn async_init() -> DynResult<AppState> {
audio_addr audio_addr
); );
tokio::spawn(audio_client::run_audio_client( let audio_shutdown_rx = shutdown_rx.clone();
task_handles.push(tokio::spawn(audio_client::run_audio_client(
audio_addr, audio_addr,
rx_audio_tx, rx_audio_tx,
tx_audio_rx, tx_audio_rx,
stream_info_tx, stream_info_tx,
decode_tx, decode_tx,
)); audio_shutdown_rx,
)));
} else { } else {
info!("Audio disabled in config, decode will not be available"); info!("Audio disabled in config, decode will not be available");
} }
@@ -282,5 +303,9 @@ async fn async_init() -> DynResult<AppState> {
)?; )?;
} }
Ok(AppState) Ok(AppState {
shutdown_tx,
task_handles,
request_tx: tx,
})
} }
+30 -2
View File
@@ -26,14 +26,22 @@ pub async fn run_remote_client(
config: RemoteClientConfig, config: RemoteClientConfig,
mut rx: mpsc::Receiver<RigRequest>, mut rx: mpsc::Receiver<RigRequest>,
state_tx: watch::Sender<RigState>, state_tx: watch::Sender<RigState>,
mut shutdown_rx: watch::Receiver<bool>,
) -> RigResult<()> { ) -> RigResult<()> {
let mut reconnect_delay = Duration::from_secs(1); let mut reconnect_delay = Duration::from_secs(1);
loop { loop {
if *shutdown_rx.borrow() {
info!("Remote client shutting down");
return Ok(());
}
info!("Remote client: connecting to {}", config.addr); info!("Remote client: connecting to {}", config.addr);
match TcpStream::connect(&config.addr).await { match TcpStream::connect(&config.addr).await {
Ok(stream) => { Ok(stream) => {
if let Err(e) = handle_connection(&config, stream, &mut rx, &state_tx).await { if let Err(e) =
handle_connection(&config, stream, &mut rx, &state_tx, &mut shutdown_rx).await
{
warn!("Remote connection dropped: {}", e); warn!("Remote connection dropped: {}", e);
} }
} }
@@ -42,7 +50,19 @@ pub async fn run_remote_client(
} }
} }
time::sleep(reconnect_delay).await; tokio::select! {
_ = time::sleep(reconnect_delay) => {}
changed = shutdown_rx.changed() => {
match changed {
Ok(()) if *shutdown_rx.borrow() => {
info!("Remote client shutting down");
return Ok(());
}
Ok(()) => {}
Err(_) => return Ok(()),
}
}
}
reconnect_delay = (reconnect_delay * 2).min(Duration::from_secs(10)); reconnect_delay = (reconnect_delay * 2).min(Duration::from_secs(10));
} }
} }
@@ -52,6 +72,7 @@ async fn handle_connection(
stream: TcpStream, stream: TcpStream,
rx: &mut mpsc::Receiver<RigRequest>, rx: &mut mpsc::Receiver<RigRequest>,
state_tx: &watch::Sender<RigState>, state_tx: &watch::Sender<RigState>,
shutdown_rx: &mut watch::Receiver<bool>,
) -> RigResult<()> { ) -> RigResult<()> {
let (reader, mut writer) = stream.into_split(); let (reader, mut writer) = stream.into_split();
let mut reader = BufReader::new(reader); let mut reader = BufReader::new(reader);
@@ -60,6 +81,13 @@ async fn handle_connection(
loop { loop {
tokio::select! { tokio::select! {
changed = shutdown_rx.changed() => {
match changed {
Ok(()) if *shutdown_rx.borrow() => return Ok(()),
Ok(()) => {}
Err(_) => return Ok(()),
}
}
_ = poll_interval.tick() => { _ = poll_interval.tick() => {
if last_poll.elapsed() < config.poll_interval { if last_poll.elapsed() < config.poll_interval {
continue; continue;
+75 -28
View File
@@ -5,9 +5,9 @@
//! Audio capture, playback, and TCP streaming for trx-server. //! Audio capture, playback, and TCP streaming for trx-server.
use std::net::SocketAddr; use std::net::SocketAddr;
use std::sync::OnceLock;
use std::time::{Duration, Instant}; use std::time::{Duration, Instant};
use std::{collections::VecDeque, sync::Mutex}; use std::{collections::VecDeque, sync::Mutex};
use std::sync::OnceLock;
use bytes::Bytes; use bytes::Bytes;
use tokio::net::{TcpListener, TcpStream}; use tokio::net::{TcpListener, TcpStream};
@@ -15,9 +15,8 @@ use tokio::sync::{broadcast, mpsc, watch};
use tracing::{error, info, warn}; use tracing::{error, info, warn};
use trx_core::audio::{ use trx_core::audio::{
read_audio_msg, write_audio_msg, AudioStreamInfo, AUDIO_MSG_APRS_DECODE, read_audio_msg, write_audio_msg, AudioStreamInfo, AUDIO_MSG_APRS_DECODE, AUDIO_MSG_CW_DECODE,
AUDIO_MSG_CW_DECODE, AUDIO_MSG_FT8_DECODE, AUDIO_MSG_RX_FRAME, AUDIO_MSG_STREAM_INFO, AUDIO_MSG_FT8_DECODE, AUDIO_MSG_RX_FRAME, AUDIO_MSG_STREAM_INFO, AUDIO_MSG_TX_FRAME,
AUDIO_MSG_TX_FRAME,
}; };
use trx_core::decode::{AprsPacket, DecodedMessage, Ft8Message}; use trx_core::decode::{AprsPacket, DecodedMessage, Ft8Message};
use trx_core::rig::state::{RigMode, RigState}; use trx_core::rig::state::{RigMode, RigState};
@@ -113,9 +112,15 @@ pub fn spawn_audio_capture(
let device_name = cfg.device.clone(); let device_name = cfg.device.clone();
std::thread::spawn(move || { std::thread::spawn(move || {
if let Err(e) = if let Err(e) = run_capture(
run_capture(sample_rate, channels, frame_duration_ms, bitrate_bps, device_name, tx, pcm_tx) sample_rate,
{ channels,
frame_duration_ms,
bitrate_bps,
device_name,
tx,
pcm_tx,
) {
error!("Audio capture thread error: {}", e); error!("Audio capture thread error: {}", e);
} }
}) })
@@ -153,7 +158,8 @@ fn run_capture(
buffer_size: cpal::BufferSize::Default, buffer_size: cpal::BufferSize::Default,
}; };
let frame_samples = (sample_rate as usize * frame_duration_ms as usize / 1000) * channels as usize; let frame_samples =
(sample_rate as usize * frame_duration_ms as usize / 1000) * channels as usize;
let opus_channels = match channels { let opus_channels = match channels {
1 => opus::Channels::Mono, 1 => opus::Channels::Mono,
@@ -178,15 +184,18 @@ fn run_capture(
)?; )?;
// Start paused — only capture when clients are connected // Start paused — only capture when clients are connected
info!("Audio capture: ready ({}Hz, {} ch, {}ms frames)", sample_rate, channels, frame_duration_ms); info!(
"Audio capture: ready ({}Hz, {} ch, {}ms frames)",
sample_rate, channels, frame_duration_ms
);
let mut pcm_buf: Vec<f32> = Vec::with_capacity(frame_samples * 2); let mut pcm_buf: Vec<f32> = Vec::with_capacity(frame_samples * 2);
let mut opus_buf = vec![0u8; 4096]; let mut opus_buf = vec![0u8; 4096];
let mut capturing = false; let mut capturing = false;
loop { loop {
let has_receivers = tx.receiver_count() > 0 let has_receivers =
|| pcm_tx.as_ref().is_some_and(|p| p.receiver_count() > 0); tx.receiver_count() > 0 || pcm_tx.as_ref().is_some_and(|p| p.receiver_count() > 0);
if has_receivers && !capturing { if has_receivers && !capturing {
let _ = stream.play(); let _ = stream.play();
@@ -281,7 +290,8 @@ fn run_playback(
buffer_size: cpal::BufferSize::Default, buffer_size: cpal::BufferSize::Default,
}; };
let frame_samples = (sample_rate as usize * frame_duration_ms as usize / 1000) * channels as usize; let frame_samples =
(sample_rate as usize * frame_duration_ms as usize / 1000) * channels as usize;
let opus_channels = match channels { let opus_channels = match channels {
1 => opus::Channels::Mono, 1 => opus::Channels::Mono,
@@ -291,7 +301,9 @@ fn run_playback(
let mut decoder = opus::Decoder::new(sample_rate, opus_channels)?; let mut decoder = opus::Decoder::new(sample_rate, opus_channels)?;
let ring = std::sync::Arc::new(std::sync::Mutex::new(std::collections::VecDeque::<f32>::with_capacity(frame_samples * 8))); let ring = std::sync::Arc::new(std::sync::Mutex::new(
std::collections::VecDeque::<f32>::with_capacity(frame_samples * 8),
));
let ring_writer = ring.clone(); let ring_writer = ring.clone();
let stream = device.build_output_stream( let stream = device.build_output_stream(
@@ -334,7 +346,9 @@ fn run_playback(
// Pause when no more packets are queued to avoid ALSA underruns // Pause when no more packets are queued to avoid ALSA underruns
if rx.is_empty() { if rx.is_empty() {
// Drain remaining samples before pausing // Drain remaining samples before pausing
std::thread::sleep(std::time::Duration::from_millis(frame_duration_ms as u64 * 2)); std::thread::sleep(std::time::Duration::from_millis(
frame_duration_ms as u64 * 2,
));
if rx.is_empty() { if rx.is_empty() {
let _ = stream.pause(); let _ = stream.pause();
playing = false; playing = false;
@@ -746,26 +760,43 @@ pub async fn run_audio_listener(
tx_audio: mpsc::Sender<Bytes>, tx_audio: mpsc::Sender<Bytes>,
stream_info: AudioStreamInfo, stream_info: AudioStreamInfo,
decode_tx: broadcast::Sender<DecodedMessage>, decode_tx: broadcast::Sender<DecodedMessage>,
mut shutdown_rx: watch::Receiver<bool>,
) -> std::io::Result<()> { ) -> std::io::Result<()> {
let listener = TcpListener::bind(addr).await?; let listener = TcpListener::bind(addr).await?;
info!("Audio listener on {}", addr); info!("Audio listener on {}", addr);
loop { loop {
let (socket, peer) = listener.accept().await?; tokio::select! {
info!("Audio client connected: {}", peer); accept = listener.accept() => {
let (socket, peer) = accept?;
info!("Audio client connected: {}", peer);
let rx_audio = rx_audio.clone(); let rx_audio = rx_audio.clone();
let tx_audio = tx_audio.clone(); let tx_audio = tx_audio.clone();
let info = stream_info.clone(); let info = stream_info.clone();
let decode_tx = decode_tx.clone(); let decode_tx = decode_tx.clone();
let client_shutdown_rx = shutdown_rx.clone();
tokio::spawn(async move { tokio::spawn(async move {
if let Err(e) = handle_audio_client(socket, peer, rx_audio, tx_audio, info, decode_tx).await { if let Err(e) = handle_audio_client(socket, peer, rx_audio, tx_audio, info, decode_tx, client_shutdown_rx).await {
warn!("Audio client {} error: {:?}", peer, e); warn!("Audio client {} error: {:?}", peer, e);
}
info!("Audio client {} disconnected", peer);
});
} }
info!("Audio client {} disconnected", peer); changed = shutdown_rx.changed() => {
}); match changed {
Ok(()) if *shutdown_rx.borrow() => {
info!("Audio listener shutting down");
break;
}
Ok(()) => {}
Err(_) => break,
}
}
}
} }
Ok(())
} }
async fn handle_audio_client( async fn handle_audio_client(
@@ -775,14 +806,14 @@ async fn handle_audio_client(
tx_audio: mpsc::Sender<Bytes>, tx_audio: mpsc::Sender<Bytes>,
stream_info: AudioStreamInfo, stream_info: AudioStreamInfo,
decode_tx: broadcast::Sender<DecodedMessage>, decode_tx: broadcast::Sender<DecodedMessage>,
mut shutdown_rx: watch::Receiver<bool>,
) -> std::io::Result<()> { ) -> std::io::Result<()> {
let (reader, writer) = socket.into_split(); let (reader, writer) = socket.into_split();
let mut reader = tokio::io::BufReader::new(reader); let mut reader = tokio::io::BufReader::new(reader);
let mut writer = tokio::io::BufWriter::new(writer); let mut writer = tokio::io::BufWriter::new(writer);
// Send stream info // Send stream info
let info_json = serde_json::to_vec(&stream_info) let info_json = serde_json::to_vec(&stream_info).map_err(std::io::Error::other)?;
.map_err(std::io::Error::other)?;
write_audio_msg(&mut writer, AUDIO_MSG_STREAM_INFO, &info_json).await?; write_audio_msg(&mut writer, AUDIO_MSG_STREAM_INFO, &info_json).await?;
// Send APRS history to newly connected client. // Send APRS history to newly connected client.
@@ -852,7 +883,23 @@ async fn handle_audio_client(
// Read TX frames from client // Read TX frames from client
loop { loop {
match read_audio_msg(&mut reader).await { let msg = tokio::select! {
msg = read_audio_msg(&mut reader) => msg,
changed = shutdown_rx.changed() => {
match changed {
Ok(()) if *shutdown_rx.borrow() => {
rx_handle.abort();
return Ok(());
}
Ok(()) => continue,
Err(_) => {
rx_handle.abort();
return Ok(());
}
}
}
};
match msg {
Ok((AUDIO_MSG_TX_FRAME, payload)) => { Ok((AUDIO_MSG_TX_FRAME, payload)) => {
let _ = tx_audio.send(Bytes::from(payload)).await; let _ = tx_audio.send(Bytes::from(payload)).await;
} }
+53 -11
View File
@@ -30,6 +30,7 @@ pub async fn run_listener(
rig_tx: mpsc::Sender<RigRequest>, rig_tx: mpsc::Sender<RigRequest>,
auth_tokens: HashSet<String>, auth_tokens: HashSet<String>,
state_rx: watch::Receiver<RigState>, state_rx: watch::Receiver<RigState>,
mut shutdown_rx: watch::Receiver<bool>,
) -> std::io::Result<()> { ) -> std::io::Result<()> {
let listener = TcpListener::bind(addr).await?; let listener = TcpListener::bind(addr).await?;
info!("Listening on {}", addr); info!("Listening on {}", addr);
@@ -37,18 +38,34 @@ pub async fn run_listener(
let validator = Arc::new(SimpleTokenValidator::new(auth_tokens)); let validator = Arc::new(SimpleTokenValidator::new(auth_tokens));
loop { loop {
let (socket, peer) = listener.accept().await?; tokio::select! {
info!("Client connected: {}", peer); accept = listener.accept() => {
let (socket, peer) = accept?;
info!("Client connected: {}", peer);
let tx = rig_tx.clone(); let tx = rig_tx.clone();
let srx = state_rx.clone(); let srx = state_rx.clone();
let validator = Arc::clone(&validator); let validator = Arc::clone(&validator);
tokio::spawn(async move { let client_shutdown_rx = shutdown_rx.clone();
if let Err(e) = handle_client(socket, peer, tx, validator, srx).await { tokio::spawn(async move {
error!("Client {} error: {:?}", peer, e); if let Err(e) = handle_client(socket, peer, tx, validator, srx, client_shutdown_rx).await {
error!("Client {} error: {:?}", peer, e);
}
});
} }
}); changed = shutdown_rx.changed() => {
match changed {
Ok(()) if *shutdown_rx.borrow() => {
info!("Listener shutting down");
break;
}
Ok(()) => {}
Err(_) => break,
}
}
}
} }
Ok(())
} }
async fn handle_client( async fn handle_client(
@@ -57,6 +74,7 @@ async fn handle_client(
tx: mpsc::Sender<RigRequest>, tx: mpsc::Sender<RigRequest>,
validator: Arc<SimpleTokenValidator>, validator: Arc<SimpleTokenValidator>,
state_rx: watch::Receiver<RigState>, state_rx: watch::Receiver<RigState>,
mut shutdown_rx: watch::Receiver<bool>,
) -> std::io::Result<()> { ) -> std::io::Result<()> {
let (reader, mut writer) = socket.into_split(); let (reader, mut writer) = socket.into_split();
let mut reader = BufReader::new(reader); let mut reader = BufReader::new(reader);
@@ -64,7 +82,19 @@ async fn handle_client(
loop { loop {
line.clear(); line.clear();
let bytes_read = reader.read_line(&mut line).await?; let bytes_read = tokio::select! {
read = reader.read_line(&mut line) => read?,
changed = shutdown_rx.changed() => {
match changed {
Ok(()) if *shutdown_rx.borrow() => {
info!("Client {} closing due to shutdown", addr);
break;
}
Ok(()) => continue,
Err(_) => break,
}
}
};
if bytes_read == 0 { if bytes_read == 0 {
info!("Client {} disconnected", addr); info!("Client {} disconnected", addr);
break; break;
@@ -141,7 +171,19 @@ async fn handle_client(
continue; continue;
} }
match resp_rx.await { match tokio::select! {
result = resp_rx => result,
changed = shutdown_rx.changed() => {
match changed {
Ok(()) if *shutdown_rx.borrow() => {
info!("Client {} request canceled due to shutdown", addr);
break;
}
Ok(()) => continue,
Err(_) => break,
}
}
} {
Ok(Ok(snapshot)) => { Ok(Ok(snapshot)) => {
let resp = ClientResponse { let resp = ClientResponse {
success: true, success: true,
+86 -29
View File
@@ -18,6 +18,7 @@ use bytes::Bytes;
use clap::{Parser, ValueEnum}; use clap::{Parser, ValueEnum};
use tokio::signal; use tokio::signal;
use tokio::sync::{broadcast, mpsc, watch}; use tokio::sync::{broadcast, mpsc, watch};
use tokio::task::JoinHandle;
use tracing::{error, info}; use tracing::{error, info};
use trx_core::audio::AudioStreamInfo; use trx_core::audio::AudioStreamInfo;
@@ -114,9 +115,7 @@ fn resolve_config(
let rig = match rig_str.as_deref() { let rig = match rig_str.as_deref() {
Some(name) => normalize_name(name), Some(name) => normalize_name(name),
None => { None => {
return Err( return Err("Rig model not specified. Use --rig or set [rig].model in config.".into())
"Rig model not specified. Use --rig or set [rig].model in config.".into(),
)
} }
}; };
if !registry.is_backend_registered(&rig) { if !registry.is_backend_registered(&rig) {
@@ -142,8 +141,7 @@ fn resolve_config(
Some("serial") | None => { Some("serial") | None => {
let (path, baud) = if let Some(ref addr) = cli.rig_addr { let (path, baud) = if let Some(ref addr) = cli.rig_addr {
parse_serial_addr(addr)? parse_serial_addr(addr)?
} else if let (Some(port), Some(baud)) = } else if let (Some(port), Some(baud)) = (&cfg.rig.access.port, cfg.rig.access.baud)
(&cfg.rig.access.port, cfg.rig.access.baud)
{ {
(port.clone(), baud) (port.clone(), baud)
} else { } else {
@@ -184,7 +182,6 @@ fn resolve_config(
}) })
} }
fn build_rig_task_config( fn build_rig_task_config(
resolved: &ResolvedConfig, resolved: &ResolvedConfig,
cfg: &ServerConfig, cfg: &ServerConfig,
@@ -212,6 +209,17 @@ fn build_rig_task_config(
} }
} }
async fn wait_for_shutdown(mut shutdown_rx: watch::Receiver<bool>) {
if *shutdown_rx.borrow() {
return;
}
while shutdown_rx.changed().await.is_ok() {
if *shutdown_rx.borrow() {
break;
}
}
}
#[tokio::main] #[tokio::main]
async fn main() -> DynResult<()> { async fn main() -> DynResult<()> {
// Phase 3B: Create bootstrap context for explicit initialization. // Phase 3B: Create bootstrap context for explicit initialization.
@@ -266,6 +274,8 @@ async fn main() -> DynResult<()> {
} }
let (tx, rx) = mpsc::channel::<RigRequest>(RIG_TASK_CHANNEL_BUFFER); let (tx, rx) = mpsc::channel::<RigRequest>(RIG_TASK_CHANNEL_BUFFER);
let mut task_handles: Vec<JoinHandle<()>> = Vec::new();
let (shutdown_tx, shutdown_rx) = watch::channel(false);
let initial_state = RigState::new_with_metadata( let initial_state = RigState::new_with_metadata(
resolved.callsign.clone(), resolved.callsign.clone(),
Some(env!("CARGO_PKG_VERSION").to_string()), Some(env!("CARGO_PKG_VERSION").to_string()),
@@ -278,8 +288,15 @@ async fn main() -> DynResult<()> {
// Keep receivers alive so channels don't close prematurely // Keep receivers alive so channels don't close prematurely
let _state_rx = state_rx; let _state_rx = state_rx;
let rig_task_config = build_rig_task_config(&resolved, &cfg, std::sync::Arc::new(bootstrap_ctx)); let rig_task_config =
let _rig_handle = tokio::spawn(rig_task::run_rig_task(rig_task_config, rx, state_tx)); build_rig_task_config(&resolved, &cfg, std::sync::Arc::new(bootstrap_ctx));
let rig_shutdown_rx = shutdown_rx.clone();
task_handles.push(tokio::spawn(async move {
if let Err(e) = rig_task::run_rig_task(rig_task_config, rx, state_tx, rig_shutdown_rx).await
{
error!("Rig task error: {:?}", e);
}
}));
if cfg.listen.enabled { if cfg.listen.enabled {
let listen_ip = cli.listen.unwrap_or(cfg.listen.listen); let listen_ip = cli.listen.unwrap_or(cfg.listen.listen);
@@ -295,15 +312,25 @@ async fn main() -> DynResult<()> {
.collect(); .collect();
let rig_tx = tx.clone(); let rig_tx = tx.clone();
let state_rx_listener = _state_rx.clone(); let state_rx_listener = _state_rx.clone();
tokio::spawn(async move { let listener_shutdown_rx = shutdown_rx.clone();
if let Err(e) = listener::run_listener(listen_addr, rig_tx, auth_tokens, state_rx_listener).await { task_handles.push(tokio::spawn(async move {
if let Err(e) = listener::run_listener(
listen_addr,
rig_tx,
auth_tokens,
state_rx_listener,
listener_shutdown_rx,
)
.await
{
error!("Listener error: {:?}", e); error!("Listener error: {:?}", e);
} }
}); }));
} }
if cfg.audio.enabled { if cfg.audio.enabled {
let audio_listen = SocketAddr::from((cli.listen.unwrap_or(cfg.audio.listen), cfg.audio.port)); let audio_listen =
SocketAddr::from((cli.listen.unwrap_or(cfg.audio.listen), cfg.audio.port));
let stream_info = AudioStreamInfo { let stream_info = AudioStreamInfo {
sample_rate: cfg.audio.sample_rate, sample_rate: cfg.audio.sample_rate,
channels: cfg.audio.channels, channels: cfg.audio.channels,
@@ -319,7 +346,8 @@ async fn main() -> DynResult<()> {
let (decode_tx, _) = broadcast::channel::<trx_core::decode::DecodedMessage>(256); let (decode_tx, _) = broadcast::channel::<trx_core::decode::DecodedMessage>(256);
if cfg.audio.rx_enabled { if cfg.audio.rx_enabled {
let _capture_thread = audio::spawn_audio_capture(&cfg.audio, rx_audio_tx.clone(), Some(pcm_tx.clone())); let _capture_thread =
audio::spawn_audio_capture(&cfg.audio, rx_audio_tx.clone(), Some(pcm_tx.clone()));
// Spawn APRS decoder task // Spawn APRS decoder task
let aprs_pcm_rx = pcm_tx.subscribe(); let aprs_pcm_rx = pcm_tx.subscribe();
@@ -327,9 +355,13 @@ async fn main() -> DynResult<()> {
let aprs_decode_tx = decode_tx.clone(); let aprs_decode_tx = decode_tx.clone();
let aprs_sr = cfg.audio.sample_rate; let aprs_sr = cfg.audio.sample_rate;
let aprs_ch = cfg.audio.channels; let aprs_ch = cfg.audio.channels;
tokio::spawn(audio::run_aprs_decoder( let aprs_shutdown_rx = shutdown_rx.clone();
aprs_sr, aprs_ch as u16, aprs_pcm_rx, aprs_state_rx, aprs_decode_tx, task_handles.push(tokio::spawn(async move {
)); tokio::select! {
_ = audio::run_aprs_decoder(aprs_sr, aprs_ch as u16, aprs_pcm_rx, aprs_state_rx, aprs_decode_tx) => {}
_ = wait_for_shutdown(aprs_shutdown_rx) => {}
}
}));
// Spawn CW decoder task // Spawn CW decoder task
let cw_pcm_rx = pcm_tx.subscribe(); let cw_pcm_rx = pcm_tx.subscribe();
@@ -337,9 +369,13 @@ async fn main() -> DynResult<()> {
let cw_decode_tx = decode_tx.clone(); let cw_decode_tx = decode_tx.clone();
let cw_sr = cfg.audio.sample_rate; let cw_sr = cfg.audio.sample_rate;
let cw_ch = cfg.audio.channels; let cw_ch = cfg.audio.channels;
tokio::spawn(audio::run_cw_decoder( let cw_shutdown_rx = shutdown_rx.clone();
cw_sr, cw_ch as u16, cw_pcm_rx, cw_state_rx, cw_decode_tx, task_handles.push(tokio::spawn(async move {
)); tokio::select! {
_ = audio::run_cw_decoder(cw_sr, cw_ch as u16, cw_pcm_rx, cw_state_rx, cw_decode_tx) => {}
_ = wait_for_shutdown(cw_shutdown_rx) => {}
}
}));
// Spawn FT8 decoder task // Spawn FT8 decoder task
let ft8_pcm_rx = pcm_tx.subscribe(); let ft8_pcm_rx = pcm_tx.subscribe();
@@ -347,27 +383,48 @@ async fn main() -> DynResult<()> {
let ft8_decode_tx = decode_tx.clone(); let ft8_decode_tx = decode_tx.clone();
let ft8_sr = cfg.audio.sample_rate; let ft8_sr = cfg.audio.sample_rate;
let ft8_ch = cfg.audio.channels; let ft8_ch = cfg.audio.channels;
tokio::spawn(audio::run_ft8_decoder( let ft8_shutdown_rx = shutdown_rx.clone();
ft8_sr, ft8_ch as u16, ft8_pcm_rx, ft8_state_rx, ft8_decode_tx, task_handles.push(tokio::spawn(async move {
)); tokio::select! {
_ = audio::run_ft8_decoder(ft8_sr, ft8_ch as u16, ft8_pcm_rx, ft8_state_rx, ft8_decode_tx) => {}
_ = wait_for_shutdown(ft8_shutdown_rx) => {}
}
}));
} }
if cfg.audio.tx_enabled { if cfg.audio.tx_enabled {
let _playback_thread = audio::spawn_audio_playback(&cfg.audio, tx_audio_rx); let _playback_thread = audio::spawn_audio_playback(&cfg.audio, tx_audio_rx);
} }
tokio::spawn(async move { let audio_shutdown_rx = shutdown_rx.clone();
if let Err(e) = task_handles.push(tokio::spawn(async move {
audio::run_audio_listener(audio_listen, rx_audio_tx, tx_audio_tx, stream_info, decode_tx) if let Err(e) = audio::run_audio_listener(
.await audio_listen,
rx_audio_tx,
tx_audio_tx,
stream_info,
decode_tx,
audio_shutdown_rx,
)
.await
{ {
error!("Audio listener error: {:?}", e); error!("Audio listener error: {:?}", e);
} }
}); }));
} }
let _tx = tx;
signal::ctrl_c().await?; signal::ctrl_c().await?;
info!("Ctrl+C received, shutting down"); info!("Ctrl+C received, shutting down");
let _ = shutdown_tx.send(true);
drop(tx);
tokio::time::sleep(Duration::from_millis(400)).await;
for handle in &task_handles {
if !handle.is_finished() {
handle.abort();
}
}
for handle in task_handles {
let _ = handle.await;
}
Ok(()) Ok(())
} }
+15 -2
View File
@@ -4,8 +4,8 @@
//! Rig task implementation using controller components. //! Rig task implementation using controller components.
use std::time::Duration;
use std::sync::Arc; use std::sync::Arc;
use std::time::Duration;
use tokio::sync::{mpsc, watch}; use tokio::sync::{mpsc, watch};
use tokio::time::{self, Instant}; use tokio::time::{self, Instant};
@@ -81,6 +81,7 @@ pub async fn run_rig_task(
config: RigTaskConfig, config: RigTaskConfig,
mut rx: mpsc::Receiver<RigRequest>, mut rx: mpsc::Receiver<RigRequest>,
state_tx: watch::Sender<RigState>, state_tx: watch::Sender<RigState>,
mut shutdown_rx: watch::Receiver<bool>,
) -> DynResult<()> { ) -> DynResult<()> {
info!("Opening rig backend {}", config.rig_model); info!("Opening rig backend {}", config.rig_model);
match &config.access { match &config.access {
@@ -88,7 +89,9 @@ pub async fn run_rig_task(
RigAccess::Tcp { addr } => info!("TCP CAT: {}", addr), RigAccess::Tcp { addr } => info!("TCP CAT: {}", addr),
} }
let mut rig: Box<dyn RigCat> = config.registry.build_rig(&config.rig_model, config.access)?; let mut rig: Box<dyn RigCat> = config
.registry
.build_rig(&config.rig_model, config.access)?;
info!("Rig backend ready"); info!("Rig backend ready");
// Initialize state machine and state // Initialize state machine and state
@@ -218,6 +221,16 @@ pub async fn run_rig_task(
} }
tokio::select! { tokio::select! {
changed = shutdown_rx.changed() => {
match changed {
Ok(()) if *shutdown_rx.borrow() => {
info!("rig_task shutting down (signal)");
break;
}
Ok(()) => {}
Err(_) => break,
}
}
_ = &mut poll_sleep => { _ = &mut poll_sleep => {
poll_sleep = Box::pin(tokio::time::sleep(current_poll_duration)); poll_sleep = Box::pin(tokio::time::sleep(current_poll_duration));
// Check if polling is paused // Check if polling is paused