refactor: convert bookmarks to typed module

2026-08-01 13:13:52 +02:00
parent 9fef0ebc7b
commit c7994347e9
8 changed files with 1052 additions and 856 deletions
@@ -0,0 +1,73 @@
+// SPDX-FileCopyrightText: 2026 Stan Grams <sjg@haxx.space>
+//
+// SPDX-License-Identifier: GPL-2.0-or-later
+
+import assert from "node:assert/strict";
+import { readFile } from "node:fs/promises";
+import test from "node:test";
+import vm from "node:vm";
+
+class ElementFixture {
+  constructor() {
+    this.value = "";
+    this.textContent = "";
+    this.innerHTML = "";
+    this.style = {};
+    this.dataset = {};
+    this.options = [];
+    this.selectedOptions = [];
+    this.children = [];
+  }
+  addEventListener() {}
+  appendChild(child) { this.children.push(child); return child; }
+  add(child) { this.options.push(child); }
+  remove(index) { this.options.splice(index, 1); }
+  focus() {}
+  querySelector() { return null; }
+}
+
+test("bookmarks register an explicit typed service for application consumers", async () => {
+  const elements = new Map();
+  const element = (id) => {
+    if (!elements.has(id)) elements.set(id, new ElementFixture());
+    return elements.get(id);
+  };
+  element("bm-scope-picker").value = "general";
+  element("bm-category-filter").options.push({ value: "" });
+  element("bm-mode-filter").options.push({ value: "" });
+  const bookmarks = [{ id: "one", name: "Local", freq_hz: 145_500_000, mode: "FM", scope: "general" }];
+  const window = {
+    trx: { modules: {} },
+    trxUi: { confirm: async () => true },
+    decoderRegistry: [],
+  };
+  const context = vm.createContext({
+    window,
+    document: {
+      getElementById: element,
+      querySelector: () => new ElementFixture(),
+      querySelectorAll: () => [],
+      createElement: () => new ElementFixture(),
+      createTextNode: (text) => ({ textContent: text }),
+      addEventListener() {},
+    },
+    fetch: async () => ({ ok: true, json: async () => bookmarks }),
+    CSS: { escape: (value) => value },
+    Element: ElementFixture,
+    Set,
+    Map,
+    Array,
+    Number,
+    String,
+    Promise,
+    console,
+  });
+  const source = await readFile(new URL("../../assets/web/generated/bookmarks.js", import.meta.url), "utf8");
+  new vm.Script(source).runInContext(context);
+  await new Promise((resolve) => setImmediate(resolve));
+
+  assert.equal(window.trx.modules.bookmarks.overlayList.length, 1);
+  assert.equal(window.trx.modules.bookmarks.overlayList[0].id, "one");
+  assert.equal(typeof window.trx.modules.bookmarks.apply, "function");
+  assert.equal(globalThis.bmOverlayList, undefined);
+});