From aadfa90a602d388b103a9ad712e9892a1fbce870 Mon Sep 17 00:00:00 2001
From: Stan Grams <sjg@haxx.space>
Date: Sat, 4 Apr 2026 15:16:20 +0200
Subject: [PATCH] [fix](trx-frontend-http): fix map not loading without manual
 page refresh

map-core.js is loaded as a dynamic script (effectively async) while
leaflet.js is a static <script defer>. When the user clicks the map tab,
Leaflet may not have executed yet, causing initAprsMap() to silently
bail on the `typeof L === "undefined"` guard with no retry. Introduce
_initMapWhenReady() that polls at 100ms intervals until both Leaflet
and map-core.js are available, showing the loading message in the
meantime. Also update autoInitIfVisible() for direct /map navigation.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Stan Grams <sjg@haxx.space>
---
 .../trx-frontend-http/assets/web/app.js       | 33 ++++++++++++++-----
 .../trx-frontend-http/assets/web/map-core.js  | 11 +++----
 2 files changed, 28 insertions(+), 16 deletions(-)

diff --git a/src/trx-client/trx-frontend/trx-frontend-http/assets/web/app.js b/src/trx-client/trx-frontend/trx-frontend-http/assets/web/app.js
index 645994e..df682f2 100644
--- a/src/trx-client/trx-frontend/trx-frontend-http/assets/web/app.js
+++ b/src/trx-client/trx-frontend/trx-frontend-http/assets/web/app.js
@@ -4469,6 +4469,29 @@ function updateTabHistory(name, replaceHistory = false) {
   window.history[method]({}, "", nextUrl);
 }
 
+// Initialise the Leaflet map, waiting for both Leaflet (L) and map-core.js
+// (window.trx.map) if they haven't loaded yet.
+let _mapInitTimer = null;
+function _initMapWhenReady() {
+  const loadingEl = document.getElementById("map-loading");
+  if (window.trx.map && typeof L !== "undefined") {
+    if (_mapInitTimer) { clearInterval(_mapInitTimer); _mapInitTimer = null; }
+    if (loadingEl) loadingEl.style.display = "none";
+    window.trx.map.initAprsMap();
+    window.trx.map.sizeAprsMapToViewport();
+    if (window.trx.map.aprsMap) setTimeout(() => window.trx.map.aprsMap.invalidateSize(), 50);
+    return;
+  }
+  // Not ready yet — show loading and poll until both are available.
+  if (loadingEl) loadingEl.style.display = "";
+  if (!_mapInitTimer) {
+    _mapInitTimer = setInterval(() => {
+      if (_activeTab !== "map") { clearInterval(_mapInitTimer); _mapInitTimer = null; return; }
+      _initMapWhenReady();
+    }, 100);
+  }
+}
+
 function navigateToTab(name, options = {}) {
   const { updateHistory = true, replaceHistory = false } = options;
   if (authEnabled && !authRole && name !== "main") {
@@ -4499,15 +4522,7 @@ function navigateToTab(name, options = {}) {
   scheduleSpectrumLayout();
   if (typeof window.loadPluginsForTab === "function") window.loadPluginsForTab(name);
   if (name === "map") {
-    const loadingEl = document.getElementById("map-loading");
-    if (window.trx.map) {
-      if (loadingEl) loadingEl.style.display = "none";
-      window.trx.map.initAprsMap();
-      window.trx.map.sizeAprsMapToViewport();
-      if (window.trx.map.aprsMap) setTimeout(() => window.trx.map.aprsMap.invalidateSize(), 50);
-    } else if (loadingEl) {
-      loadingEl.style.display = "";
-    }
+    _initMapWhenReady();
   }
   if (name === "statistics") {
     window.trx.map?.scheduleStatsRender();
diff --git a/src/trx-client/trx-frontend/trx-frontend-http/assets/web/map-core.js b/src/trx-client/trx-frontend/trx-frontend-http/assets/web/map-core.js
index ff77cd5..3c18bad 100644
--- a/src/trx-client/trx-frontend/trx-frontend-http/assets/web/map-core.js
+++ b/src/trx-client/trx-frontend/trx-frontend-http/assets/web/map-core.js
@@ -3427,15 +3427,12 @@
   }
 
 
-  // Auto-init map if the map tab is already visible (e.g. direct /map navigation)
+  // Auto-init map if the map tab is already visible (e.g. direct /map navigation).
+  // Delegates to _initMapWhenReady() in app.js which handles the Leaflet load race.
   function autoInitIfVisible() {
     const panel = document.getElementById("tab-map");
-    if (panel && panel.style.display !== "none") {
-      const loadingEl = document.getElementById("map-loading");
-      if (loadingEl) loadingEl.style.display = "none";
-      initAprsMap();
-      sizeAprsMapToViewport();
-      if (aprsMap) setTimeout(() => aprsMap.invalidateSize(), 50);
+    if (panel && panel.style.display !== "none" && typeof _initMapWhenReady === "function") {
+      _initMapWhenReady();
     }
   }