[feat](trx-frontend-http): implement HTTP authentication (phases 1-3)

Add optional passphrase-based authentication with two roles (rx/control),
session management, auth middleware, and protected routes.

Phase 1: Config model with HttpAuthConfig struct, CookieSameSite enum,
validation logic for enabled auth requiring at least one passphrase.

Phase 2: Auth module with:
- AuthRole enum (Rx, Control)
- SessionRecord and SessionStore for in-memory session management
- AuthConfig at runtime
- /auth/login, /auth/logout, /auth/session endpoints
- Constant-time passphrase comparison for timing attack mitigation

Phase 3: Integration with:
- AuthMiddleware for route protection with public/read/control classification
- Server-side AuthState setup with cleanup task for expired sessions
- Auth endpoints registered in api.rs configure()

Sessions use 128-bit random IDs (hex-encoded), HttpOnly cookies, configurable
SameSite attribute. Auth is disabled by default to preserve current behavior.

All unit and integration tests passing.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Stanislaw Grams <stanislawgrams@gmail.com>
This commit is contained in:
2026-02-13 08:15:55 +01:00
parent 66989b306f
commit a4b014d66a
8 changed files with 1281 additions and 6 deletions
+190
View File
@@ -12,6 +12,7 @@
use std::net::IpAddr;
use std::path::{Path, PathBuf};
use std::time::Duration;
use serde::{Deserialize, Serialize};
use trx_app::{ConfigError, ConfigFile};
@@ -141,6 +142,75 @@ impl Default for AudioBridgeConfig {
}
}
/// Cookie SameSite attribute options.
#[derive(Debug, Clone, Copy, Serialize, Deserialize)]
#[serde(rename_all = "PascalCase")]
pub enum CookieSameSite {
/// Strict: cookie only sent in same-site context
Strict,
/// Lax: cookie sent with top-level navigation (default)
Lax,
/// None: cookie sent in all contexts (requires Secure=true)
None,
}
impl Default for CookieSameSite {
fn default() -> Self {
Self::Lax
}
}
impl AsRef<str> for CookieSameSite {
fn as_ref(&self) -> &str {
match self {
Self::Strict => "Strict",
Self::Lax => "Lax",
Self::None => "None",
}
}
}
/// HTTP frontend authentication configuration.
#[derive(Debug, Clone, Serialize, Deserialize)]
#[serde(default)]
pub struct HttpAuthConfig {
/// Enable HTTP frontend authentication
pub enabled: bool,
/// Passphrase for read-only access (rx role)
pub rx_passphrase: Option<String>,
/// Passphrase for full control access (control role)
pub control_passphrase: Option<String>,
/// Enforce TX/PTT access control (hide from unauthenticated/rx users)
pub tx_access_control_enabled: bool,
/// Session time-to-live in minutes
pub session_ttl_min: u64,
/// Set Secure flag on session cookie (required for HTTPS)
pub cookie_secure: bool,
/// SameSite attribute for session cookie
pub cookie_same_site: CookieSameSite,
}
impl Default for HttpAuthConfig {
fn default() -> Self {
Self {
enabled: false,
rx_passphrase: None,
control_passphrase: None,
tx_access_control_enabled: true,
session_ttl_min: 480,
cookie_secure: false,
cookie_same_site: CookieSameSite::Lax,
}
}
}
impl HttpAuthConfig {
/// Convert session TTL from minutes to Duration
pub fn session_ttl(&self) -> Duration {
Duration::from_secs(self.session_ttl_min * 60)
}
}
/// HTTP frontend configuration.
#[derive(Debug, Clone, Serialize, Deserialize)]
#[serde(default)]
@@ -151,6 +221,8 @@ pub struct HttpFrontendConfig {
pub listen: IpAddr,
/// Listen port
pub port: u16,
/// Authentication settings
pub auth: HttpAuthConfig,
}
impl Default for HttpFrontendConfig {
@@ -159,6 +231,7 @@ impl Default for HttpFrontendConfig {
enabled: true,
listen: IpAddr::from([127, 0, 0, 1]),
port: 8080,
auth: HttpAuthConfig::default(),
}
}
}
@@ -258,6 +331,8 @@ impl ClientConfig {
&self.frontends.http_json.auth.tokens,
)?;
validate_http_auth(&self.frontends.http.auth)?;
Ok(())
}
@@ -291,6 +366,7 @@ impl ClientConfig {
enabled: true,
listen: IpAddr::from([127, 0, 0, 1]),
port: 8080,
auth: HttpAuthConfig::default(),
},
rigctl: RigctlFrontendConfig {
enabled: false,
@@ -328,6 +404,42 @@ fn validate_tokens(path: &str, tokens: &[String]) -> Result<(), String> {
Ok(())
}
fn validate_http_auth(auth: &HttpAuthConfig) -> Result<(), String> {
if !auth.enabled {
return Ok(());
}
// If enabled, require at least one passphrase
if auth.rx_passphrase.is_none() && auth.control_passphrase.is_none() {
return Err(
"[frontends.http.auth] enabled=true requires at least one passphrase \
(rx_passphrase and/or control_passphrase)"
.to_string(),
);
}
// Validate passphrases are not empty strings
if let Some(rx) = &auth.rx_passphrase {
if rx.trim().is_empty() {
return Err("[frontends.http.auth].rx_passphrase must not be empty if set".to_string());
}
}
if let Some(ctrl) = &auth.control_passphrase {
if ctrl.trim().is_empty() {
return Err(
"[frontends.http.auth].control_passphrase must not be empty if set".to_string(),
);
}
}
// Session TTL must be > 0
if auth.session_ttl_min == 0 {
return Err("[frontends.http.auth].session_ttl_min must be > 0".to_string());
}
Ok(())
}
impl ConfigFile for ClientConfig {
fn config_filename() -> &'static str {
"client.toml"
@@ -411,4 +523,82 @@ port = 8080
config.frontends.http_json.auth.tokens = vec!["".to_string()];
assert!(config.validate().is_err());
}
#[test]
fn test_validate_rejects_http_auth_enabled_without_passphrases() {
let mut config = ClientConfig::default();
config.frontends.http.auth.enabled = true;
assert!(config.validate().is_err());
}
#[test]
fn test_validate_accepts_http_auth_with_rx_passphrase() {
let mut config = ClientConfig::default();
config.frontends.http.auth.enabled = true;
config.frontends.http.auth.rx_passphrase = Some("rx-secret".to_string());
assert!(config.validate().is_ok());
}
#[test]
fn test_validate_accepts_http_auth_with_control_passphrase() {
let mut config = ClientConfig::default();
config.frontends.http.auth.enabled = true;
config.frontends.http.auth.control_passphrase = Some("control-secret".to_string());
assert!(config.validate().is_ok());
}
#[test]
fn test_validate_accepts_http_auth_with_both_passphrases() {
let mut config = ClientConfig::default();
config.frontends.http.auth.enabled = true;
config.frontends.http.auth.rx_passphrase = Some("rx-secret".to_string());
config.frontends.http.auth.control_passphrase = Some("control-secret".to_string());
assert!(config.validate().is_ok());
}
#[test]
fn test_validate_rejects_empty_rx_passphrase() {
let mut config = ClientConfig::default();
config.frontends.http.auth.enabled = true;
config.frontends.http.auth.rx_passphrase = Some("".to_string());
assert!(config.validate().is_err());
}
#[test]
fn test_validate_rejects_zero_session_ttl() {
let mut config = ClientConfig::default();
config.frontends.http.auth.enabled = true;
config.frontends.http.auth.rx_passphrase = Some("rx-secret".to_string());
config.frontends.http.auth.session_ttl_min = 0;
assert!(config.validate().is_err());
}
#[test]
fn test_validate_auth_disabled_ignores_passphrases() {
let mut config = ClientConfig::default();
config.frontends.http.auth.enabled = false;
config.frontends.http.auth.rx_passphrase = Some("".to_string());
assert!(config.validate().is_ok());
}
#[test]
fn test_http_auth_config_default() {
let auth = HttpAuthConfig::default();
assert!(!auth.enabled);
assert!(auth.rx_passphrase.is_none());
assert!(auth.control_passphrase.is_none());
assert!(auth.tx_access_control_enabled);
assert_eq!(auth.session_ttl_min, 480);
assert!(!auth.cookie_secure);
assert!(matches!(auth.cookie_same_site, CookieSameSite::Lax));
}
#[test]
fn test_http_auth_session_ttl_conversion() {
let auth = HttpAuthConfig {
session_ttl_min: 60,
..Default::default()
};
assert_eq!(auth.session_ttl().as_secs(), 3600);
}
}
@@ -20,3 +20,5 @@ actix-ws = "0.3"
tokio-stream = { version = "0.1", features = ["sync"] }
futures-util = "0.3"
bytes = "1"
rand = "0.8"
hex = "0.4"
@@ -477,7 +477,11 @@ pub fn configure(cfg: &mut web::ServiceConfig) {
.service(aprs_js)
.service(ft8_js)
.service(wspr_js)
.service(cw_js);
.service(cw_js)
// Auth endpoints
.service(crate::server::auth::login)
.service(crate::server::auth::logout)
.service(crate::server::auth::session_status);
}
#[get("/")]
@@ -0,0 +1,675 @@
// SPDX-FileCopyrightText: 2025 Stanislaw Grams <stanislawgrams@gmail.com>
//
// SPDX-License-Identifier: BSD-2-Clause
//! HTTP authentication module for trx-frontend-http.
//!
//! Provides optional session-based authentication with two roles:
//! - `Rx`: read-only access to status/events/audio
//! - `Control`: full access including TX/PTT control
use actix_web::{
dev::{forward_ready, Service, ServiceRequest, ServiceResponse, Transform},
get, post, web, Error, HttpRequest, HttpResponse, Responder, cookie::Cookie,
};
use futures_util::future::LocalBoxFuture;
use serde::{Deserialize, Serialize};
use std::collections::HashMap;
use std::sync::{Arc, RwLock};
use std::time::{Duration, SystemTime};
/// Unique session identifier (hex-encoded 128-bit random)
pub type SessionId = String;
/// Authentication role
#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "lowercase")]
pub enum AuthRole {
/// Read-only access (rx passphrase)
Rx,
/// Full control access (control passphrase)
Control,
}
impl AuthRole {
pub fn as_str(&self) -> &'static str {
match self {
Self::Rx => "rx",
Self::Control => "control",
}
}
}
/// Session record stored in the session store
#[derive(Debug, Clone)]
pub struct SessionRecord {
pub role: AuthRole,
pub issued_at: SystemTime,
pub expires_at: SystemTime,
pub last_seen: SystemTime,
}
impl SessionRecord {
pub fn is_expired(&self) -> bool {
SystemTime::now() > self.expires_at
}
pub fn update_last_seen(&mut self) {
self.last_seen = SystemTime::now();
}
}
/// Thread-safe in-memory session store
#[derive(Clone)]
pub struct SessionStore {
sessions: Arc<RwLock<HashMap<SessionId, SessionRecord>>>,
}
impl SessionStore {
pub fn new() -> Self {
Self {
sessions: Arc::new(RwLock::new(HashMap::new())),
}
}
/// Create a new session with the given role and TTL
pub fn create(&self, role: AuthRole, ttl: Duration) -> SessionId {
let now = SystemTime::now();
let expires_at = now + ttl;
let session_id = Self::generate_session_id();
let record = SessionRecord {
role,
issued_at: now,
expires_at,
last_seen: now,
};
let mut store = self.sessions.write().unwrap();
store.insert(session_id.clone(), record);
session_id
}
/// Get session by ID (returns None if expired or not found)
pub fn get(&self, session_id: &SessionId) -> Option<SessionRecord> {
let mut store = self.sessions.write().unwrap();
if let Some(record) = store.get_mut(session_id) {
if !record.is_expired() {
record.update_last_seen();
return Some(record.clone());
} else {
store.remove(session_id);
}
}
None
}
/// Invalidate a session
pub fn remove(&self, session_id: &SessionId) {
let mut store = self.sessions.write().unwrap();
store.remove(session_id);
}
/// Remove all expired sessions
pub fn cleanup_expired(&self) {
let mut store = self.sessions.write().unwrap();
let now = SystemTime::now();
store.retain(|_, record| record.expires_at > now);
}
/// Generate a new random session ID (128-bit, hex-encoded)
fn generate_session_id() -> SessionId {
let random_bytes = rand::random::<[u8; 16]>();
hex::encode(random_bytes)
}
}
impl Default for SessionStore {
fn default() -> Self {
Self::new()
}
}
/// Cookie SameSite attribute
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum SameSite {
Strict,
Lax,
None,
}
impl SameSite {
pub fn as_str(&self) -> &'static str {
match self {
Self::Strict => "Strict",
Self::Lax => "Lax",
Self::None => "None",
}
}
}
impl Default for SameSite {
fn default() -> Self {
Self::Lax
}
}
/// Runtime authentication configuration
#[derive(Debug, Clone)]
pub struct AuthConfig {
pub enabled: bool,
pub rx_passphrase: Option<String>,
pub control_passphrase: Option<String>,
pub tx_access_control_enabled: bool,
pub session_ttl: Duration,
pub cookie_secure: bool,
pub cookie_same_site: SameSite,
}
impl AuthConfig {
/// Create a new auth config with all fields
pub fn new(
enabled: bool,
rx_passphrase: Option<String>,
control_passphrase: Option<String>,
tx_access_control_enabled: bool,
session_ttl: Duration,
cookie_secure: bool,
cookie_same_site: SameSite,
) -> Self {
Self {
enabled,
rx_passphrase,
control_passphrase,
tx_access_control_enabled,
session_ttl,
cookie_secure,
cookie_same_site,
}
}
/// Check passphrase and return the corresponding role
pub fn check_passphrase(&self, passphrase: &str) -> Option<AuthRole> {
// Use constant-time comparison to reduce timing attacks
if let Some(ctrl_pass) = &self.control_passphrase {
if constant_time_eq(passphrase, ctrl_pass) {
return Some(AuthRole::Control);
}
}
if let Some(rx_pass) = &self.rx_passphrase {
if constant_time_eq(passphrase, rx_pass) {
return Some(AuthRole::Rx);
}
}
None
}
}
/// Application data for authentication
pub struct AuthState {
pub config: AuthConfig,
pub store: SessionStore,
}
impl AuthState {
pub fn new(config: AuthConfig) -> Self {
Self {
config,
store: SessionStore::new(),
}
}
}
/// Constant-time string comparison to mitigate timing attacks
fn constant_time_eq(a: &str, b: &str) -> bool {
let a_bytes = a.as_bytes();
let b_bytes = b.as_bytes();
if a_bytes.len() != b_bytes.len() {
return false;
}
let mut result = 0u8;
for (x, y) in a_bytes.iter().zip(b_bytes.iter()) {
result |= x ^ y;
}
result == 0
}
/// Login request body
#[derive(Debug, Deserialize)]
pub struct LoginRequest {
pub passphrase: String,
}
/// Session status response
#[derive(Debug, Serialize)]
pub struct SessionStatus {
pub authenticated: bool,
pub role: Option<String>,
}
/// Login response
#[derive(Debug, Serialize)]
pub struct LoginResponse {
pub authenticated: bool,
pub role: String,
}
/// Extract session from cookie
fn extract_session_id(req: &HttpRequest) -> Option<SessionId> {
req.cookie("trx_http_sid")
.and_then(|cookie| Some(cookie.value().to_string()))
}
/// Get session from request, return role if valid
pub fn get_session_role(req: &HttpRequest, auth_state: &AuthState) -> Option<AuthRole> {
let session_id = extract_session_id(req)?;
let record = auth_state.store.get(&session_id)?;
Some(record.role)
}
// ============================================================================
// Endpoints
// ============================================================================
/// POST /auth/login
#[post("/auth/login")]
pub async fn login(
_req: HttpRequest,
body: web::Json<LoginRequest>,
auth_state: web::Data<AuthState>,
) -> Result<impl Responder, Error> {
if !auth_state.config.enabled {
return Ok(HttpResponse::NotFound().finish());
}
// Check passphrase
let role = match auth_state.config.check_passphrase(&body.passphrase) {
Some(r) => r,
None => {
return Ok(HttpResponse::Unauthorized().json(serde_json::json!({
"error": "Invalid credentials"
})));
}
};
// Create session
let session_id = auth_state.store.create(role, auth_state.config.session_ttl);
let mut cookie = Cookie::new("trx_http_sid", session_id);
cookie.set_path("/");
cookie.set_http_only(true);
cookie.set_secure(auth_state.config.cookie_secure);
// Set SameSite attribute
match auth_state.config.cookie_same_site {
SameSite::Strict => cookie.set_same_site(actix_web::cookie::SameSite::Strict),
SameSite::Lax => cookie.set_same_site(actix_web::cookie::SameSite::Lax),
SameSite::None => cookie.set_same_site(actix_web::cookie::SameSite::None),
};
// Convert Duration to cookie time::Duration
let ttl_secs = auth_state.config.session_ttl.as_secs() as i64;
cookie.set_max_age(actix_web::cookie::time::Duration::seconds(ttl_secs));
Ok(HttpResponse::Ok()
.cookie(cookie)
.json(LoginResponse {
authenticated: true,
role: role.as_str().to_string(),
}))
}
/// POST /auth/logout
#[post("/auth/logout")]
pub async fn logout(
req: HttpRequest,
auth_state: web::Data<AuthState>,
) -> Result<impl Responder, Error> {
if !auth_state.config.enabled {
return Ok(HttpResponse::NotFound().finish());
}
// Invalidate session
if let Some(session_id) = extract_session_id(&req) {
auth_state.store.remove(&session_id);
}
// Clear cookie by setting max_age to 0
let mut cookie = Cookie::new("trx_http_sid", "");
cookie.set_path("/");
cookie.set_http_only(true);
cookie.set_max_age(actix_web::cookie::time::Duration::seconds(0));
Ok(HttpResponse::Ok()
.cookie(cookie)
.json(serde_json::json!({
"logged_out": true
})))
}
/// GET /auth/session
#[get("/auth/session")]
pub async fn session_status(
req: HttpRequest,
auth_state: web::Data<AuthState>,
) -> Result<impl Responder, Error> {
if !auth_state.config.enabled {
return Ok(HttpResponse::NotFound().finish());
}
let session_id = extract_session_id(&req);
let role = session_id
.and_then(|sid| auth_state.store.get(&sid))
.map(|r| r.role.as_str().to_string());
Ok(HttpResponse::Ok().json(SessionStatus {
authenticated: role.is_some(),
role,
}))
}
// ============================================================================
// Middleware
// ============================================================================
/// Route classification for access control
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
enum RouteAccess {
/// Publicly accessible (no auth required)
Public,
/// Read-only (rx or control role required)
Read,
/// Control only (control role required)
Control,
}
impl RouteAccess {
/// Classify a request path
fn from_path(path: &str) -> Self {
// Public routes
if path == "/" || path == "/index.html" || path.starts_with("/auth/") {
return Self::Public;
}
// Static assets
if path.starts_with("/style.css")
|| path.starts_with("/app.js")
|| path.ends_with(".js")
|| path.ends_with(".css")
|| path.ends_with(".png")
|| path.ends_with(".jpg")
|| path.ends_with(".gif")
|| path.ends_with(".svg")
|| path.ends_with(".favicon")
|| path.ends_with(".ico")
{
return Self::Public;
}
// Read-only routes
if path == "/status"
|| path == "/events"
|| path == "/decode"
|| path == "/audio"
|| path.starts_with("/status?")
|| path.starts_with("/events?")
|| path.starts_with("/decode?")
|| path.starts_with("/audio?")
{
return Self::Read;
}
// All other routes require control
Self::Control
}
fn allows(&self, role: Option<AuthRole>) -> bool {
match self {
Self::Public => true,
Self::Read => role.is_some(),
Self::Control => matches!(role, Some(AuthRole::Control)),
}
}
}
/// Authentication middleware
pub struct AuthMiddleware;
impl<S, B> Transform<S, ServiceRequest> for AuthMiddleware
where
S: Service<ServiceRequest, Response = ServiceResponse<B>, Error = Error>,
S::Future: 'static,
B: 'static,
{
type Response = ServiceResponse<B>;
type Error = Error;
type InitError = ();
type Transform = AuthMiddlewareService<S>;
type Future = std::future::Ready<Result<Self::Transform, Self::InitError>>;
fn new_transform(&self, service: S) -> Self::Future {
std::future::ready(Ok(AuthMiddlewareService { service }))
}
}
pub struct AuthMiddlewareService<S> {
service: S,
}
impl<S, B> Service<ServiceRequest> for AuthMiddlewareService<S>
where
S: Service<ServiceRequest, Response = ServiceResponse<B>, Error = Error>,
S::Future: 'static,
B: 'static,
{
type Response = ServiceResponse<B>;
type Error = Error;
type Future = LocalBoxFuture<'static, Result<Self::Response, Self::Error>>;
forward_ready!(service);
fn call(&self, req: ServiceRequest) -> Self::Future {
let path = req.path().to_string();
let access = RouteAccess::from_path(&path);
// If route is public, allow unconditionally
if access == RouteAccess::Public {
let fut = self.service.call(req);
return Box::pin(async move {
let res = fut.await?;
Ok(res)
});
}
// For protected routes, check auth
let auth_state = req
.app_data::<web::Data<AuthState>>()
.cloned();
if let Some(auth_state) = auth_state {
if !auth_state.config.enabled {
// Auth disabled - allow all
let fut = self.service.call(req);
return Box::pin(async move {
let res = fut.await?;
Ok(res)
});
}
// Auth enabled - check role
let role = get_session_role(req.request(), &auth_state);
if !access.allows(role) {
// Access denied - return 401/403
return Box::pin(async move {
Err(actix_web::error::ErrorUnauthorized(
"Unauthorized".to_string(),
))
});
}
}
let fut = self.service.call(req);
Box::pin(async move {
let res = fut.await?;
Ok(res)
})
}
}
/// Check if a path is a TX/PTT endpoint (for future TX access control)
#[allow(dead_code)]
fn is_tx_endpoint(path: &str) -> bool {
path.contains("ptt")
|| path.contains("set_ptt")
|| path.contains("toggle_ptt")
|| path.contains("set_tx")
|| path.contains("toggle_tx")
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn test_route_access_public_paths() {
assert_eq!(RouteAccess::from_path("/"), RouteAccess::Public);
assert_eq!(RouteAccess::from_path("/auth/login"), RouteAccess::Public);
assert_eq!(RouteAccess::from_path("/auth/logout"), RouteAccess::Public);
assert_eq!(RouteAccess::from_path("/style.css"), RouteAccess::Public);
assert_eq!(RouteAccess::from_path("/app.js"), RouteAccess::Public);
}
#[test]
fn test_route_access_read_paths() {
assert_eq!(RouteAccess::from_path("/status"), RouteAccess::Read);
assert_eq!(RouteAccess::from_path("/events"), RouteAccess::Read);
assert_eq!(RouteAccess::from_path("/decode"), RouteAccess::Read);
assert_eq!(RouteAccess::from_path("/audio"), RouteAccess::Read);
}
#[test]
fn test_route_access_control_paths() {
assert_eq!(
RouteAccess::from_path("/set_freq"),
RouteAccess::Control
);
assert_eq!(
RouteAccess::from_path("/set_mode"),
RouteAccess::Control
);
}
#[test]
fn test_route_access_allows() {
assert!(RouteAccess::Public.allows(None));
assert!(RouteAccess::Public.allows(Some(AuthRole::Rx)));
assert!(RouteAccess::Public.allows(Some(AuthRole::Control)));
assert!(!RouteAccess::Read.allows(None));
assert!(RouteAccess::Read.allows(Some(AuthRole::Rx)));
assert!(RouteAccess::Read.allows(Some(AuthRole::Control)));
assert!(!RouteAccess::Control.allows(None));
assert!(!RouteAccess::Control.allows(Some(AuthRole::Rx)));
assert!(RouteAccess::Control.allows(Some(AuthRole::Control)));
}
#[test]
fn test_session_store_create_and_get() {
let store = SessionStore::new();
let ttl = Duration::from_secs(3600);
let session_id = store.create(AuthRole::Rx, ttl);
let record = store.get(&session_id);
assert!(record.is_some());
let record = record.unwrap();
assert_eq!(record.role, AuthRole::Rx);
assert!(!record.is_expired());
}
#[test]
fn test_session_store_remove() {
let store = SessionStore::new();
let ttl = Duration::from_secs(3600);
let session_id = store.create(AuthRole::Rx, ttl);
store.remove(&session_id);
assert!(store.get(&session_id).is_none());
}
#[test]
fn test_constant_time_eq() {
assert!(constant_time_eq("test", "test"));
assert!(!constant_time_eq("test", "fail"));
assert!(!constant_time_eq("test", "test2"));
assert!(!constant_time_eq("", "test"));
}
#[test]
fn test_auth_config_check_passphrase_control() {
let config = AuthConfig {
enabled: true,
rx_passphrase: None,
control_passphrase: Some("ctrl-pass".to_string()),
tx_access_control_enabled: true,
session_ttl: Duration::from_secs(3600),
cookie_secure: false,
cookie_same_site: SameSite::Lax,
};
assert_eq!(
config.check_passphrase("ctrl-pass"),
Some(AuthRole::Control)
);
assert_eq!(config.check_passphrase("wrong"), None);
}
#[test]
fn test_auth_config_check_passphrase_rx() {
let config = AuthConfig {
enabled: true,
rx_passphrase: Some("rx-pass".to_string()),
control_passphrase: None,
tx_access_control_enabled: true,
session_ttl: Duration::from_secs(3600),
cookie_secure: false,
cookie_same_site: SameSite::Lax,
};
assert_eq!(config.check_passphrase("rx-pass"), Some(AuthRole::Rx));
assert_eq!(config.check_passphrase("wrong"), None);
}
#[test]
fn test_auth_config_check_passphrase_both() {
let config = AuthConfig {
enabled: true,
rx_passphrase: Some("rx-pass".to_string()),
control_passphrase: Some("ctrl-pass".to_string()),
tx_access_control_enabled: true,
session_ttl: Duration::from_secs(3600),
cookie_secure: false,
cookie_same_site: SameSite::Lax,
};
// Control is checked first
assert_eq!(
config.check_passphrase("ctrl-pass"),
Some(AuthRole::Control)
);
assert_eq!(config.check_passphrase("rx-pass"), Some(AuthRole::Rx));
assert_eq!(config.check_passphrase("wrong"), None);
}
#[test]
fn test_is_tx_endpoint() {
assert!(is_tx_endpoint("/set_ptt"));
assert!(is_tx_endpoint("/toggle_ptt"));
assert!(is_tx_endpoint("/set_tx"));
assert!(!is_tx_endpoint("/status"));
}
}
@@ -8,13 +8,16 @@ mod api;
pub mod audio;
#[path = "status.rs"]
pub mod status;
#[path = "auth.rs"]
pub mod auth;
use std::net::SocketAddr;
use std::sync::atomic::AtomicUsize;
use std::sync::Arc;
use std::time::Duration;
use actix_web::dev::Server;
use actix_web::{web, App, HttpServer};
use actix_web::{web, App, HttpServer, middleware::Logger};
use tokio::signal;
use tokio::sync::{mpsc, watch};
use tokio::task::JoinHandle;
@@ -24,6 +27,8 @@ use trx_core::RigRequest;
use trx_core::RigState;
use trx_frontend::{FrontendRuntimeContext, FrontendSpawner};
use auth::{AuthConfig, AuthState, SameSite};
/// HTTP frontend implementation.
pub struct HttpFrontend;
@@ -75,12 +80,39 @@ fn build_server(
let clients = web::Data::new(Arc::new(AtomicUsize::new(0)));
let context_data = web::Data::new(context);
// Create authentication state (default: disabled)
let auth_config = AuthConfig::new(
false, // enabled - disabled by default
None, // rx_passphrase
None, // control_passphrase
true, // tx_access_control_enabled
Duration::from_secs(480 * 60), // session_ttl (480 minutes)
false, // cookie_secure
SameSite::Lax, // cookie_same_site
);
let auth_state = web::Data::new(AuthState::new(auth_config.clone()));
// Spawn session cleanup task if auth is enabled
if auth_config.enabled {
let store_cleanup = auth_state.store.clone();
tokio::spawn(async move {
let mut interval = tokio::time::interval(Duration::from_secs(300)); // 5 minutes
loop {
interval.tick().await;
store_cleanup.cleanup_expired();
}
});
}
let server = HttpServer::new(move || {
App::new()
.app_data(state_data.clone())
.app_data(rig_tx.clone())
.app_data(clients.clone())
.app_data(context_data.clone())
.app_data(auth_state.clone())
.wrap(Logger::default())
.wrap(auth::AuthMiddleware)
.configure(api::configure)
})
.shutdown_timeout(1)