From 832fac1d64f06d00a0f429d73d2cc6ba9d05af41 Mon Sep 17 00:00:00 2001
From: Stan Grams <sjg@haxx.space>
Date: Sun, 1 Mar 2026 19:26:04 +0100
Subject: [PATCH] [fix](trx-rs): refine wfm denoise and favicon handling

Co-authored-by: OpenAI Codex <codex@openai.com>
Signed-off-by: Stan Grams <sjg@haxx.space>
---
 .../trx-frontend-http/assets/web/app.js       |  5 ++---
 .../trx-frontend-http/assets/web/index.html   |  8 ++++----
 .../trx-frontend/trx-frontend-http/src/api.rs |  6 +++---
 src/trx-core/src/rig/state.rs                 |  1 +
 .../trx-backend-soapysdr/src/demod/wfm.rs     | 19 ++++++++++++++++++-
 5 files changed, 28 insertions(+), 11 deletions(-)

diff --git a/src/trx-client/trx-frontend/trx-frontend-http/assets/web/app.js b/src/trx-client/trx-frontend/trx-frontend-http/assets/web/app.js
index d76dae6..c88802b 100644
--- a/src/trx-client/trx-frontend/trx-frontend-http/assets/web/app.js
+++ b/src/trx-client/trx-frontend/trx-frontend-http/assets/web/app.js
@@ -1431,7 +1431,7 @@ function render(update) {
     if (wfmDenoiseEl && (typeof update.filter.wfm_denoise === "string" || typeof update.filter.wfm_denoise === "boolean")) {
       const nextDenoise = typeof update.filter.wfm_denoise === "string"
         ? normalizeWfmDenoiseLevel(update.filter.wfm_denoise)
-        : (update.filter.wfm_denoise ? "auto" : "low");
+        : (update.filter.wfm_denoise ? "auto" : "off");
       if (wfmDenoiseEl.value !== nextDenoise) {
         wfmDenoiseEl.value = nextDenoise;
         saveSetting("wfmDenoise", nextDenoise);
@@ -2994,8 +2994,7 @@ function levelFromChannels(channels, frameCount) {
 
 function normalizeWfmDenoiseLevel(value) {
   const next = String(value ?? "").toLowerCase();
-  if (next === "auto" || next === "low" || next === "medium" || next === "high") return next;
-  if (next === "off") return "low";
+  if (next === "off" || next === "auto" || next === "low" || next === "medium" || next === "high") return next;
   return "auto";
 }
 
diff --git a/src/trx-client/trx-frontend/trx-frontend-http/assets/web/index.html b/src/trx-client/trx-frontend/trx-frontend-http/assets/web/index.html
index 5367965..aa33639 100644
--- a/src/trx-client/trx-frontend/trx-frontend-http/assets/web/index.html
+++ b/src/trx-client/trx-frontend/trx-frontend-http/assets/web/index.html
@@ -4,10 +4,9 @@
   <meta charset="utf-8">
   <meta name="viewport" content="width=device-width, initial-scale=1.0, viewport-fit=cover">
   <title>trx-rs v{ver}</title>
-  <link rel="icon" type="image/png" sizes="32x32" href="/favicon.png?v=4" />
-  <link rel="icon" type="image/png" sizes="16x16" href="/favicon.png?v=4" />
-  <link rel="shortcut icon" href="/favicon.png?v=4" />
-  <link rel="apple-touch-icon" sizes="180x180" href="/favicon.png?v=4" />
+  <link rel="icon" type="image/png" sizes="any" href="/favicon.ico?v=5" />
+  <link rel="shortcut icon" href="/favicon.ico?v=5" />
+  <link rel="apple-touch-icon" sizes="180x180" href="/favicon.png?v=5" />
   <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@fontsource/dseg14-classic/400.css" />
   <link rel="stylesheet" href="/style.css" />
   <link rel="stylesheet" href="https://unpkg.com/leaflet@1.9.4/dist/leaflet.css" />
@@ -179,6 +178,7 @@
                   <label class="wfm-control">
                     <span class="wfm-control-label">Denoise Level</span>
                     <select id="wfm-denoise" class="status-input">
+                      <option value="off">Off</option>
                       <option value="auto">Auto</option>
                       <option value="low">Low</option>
                       <option value="medium">Medium</option>
diff --git a/src/trx-client/trx-frontend/trx-frontend-http/src/api.rs b/src/trx-client/trx-frontend/trx-frontend-http/src/api.rs
index df30bed..7392bb8 100644
--- a/src/trx-client/trx-frontend/trx-frontend-http/src/api.rs
+++ b/src/trx-client/trx-frontend/trx-frontend-http/src/api.rs
@@ -944,9 +944,9 @@ async fn index() -> impl Responder {
 
 #[get("/favicon.ico")]
 async fn favicon() -> impl Responder {
-    HttpResponse::TemporaryRedirect()
-        .insert_header((header::LOCATION, "/favicon.png?v=4"))
-        .finish()
+    HttpResponse::Ok()
+        .insert_header((header::CONTENT_TYPE, "image/png"))
+        .body(FAVICON_BYTES)
 }
 
 #[get("/favicon.png")]
diff --git a/src/trx-core/src/rig/state.rs b/src/trx-core/src/rig/state.rs
index edfdf65..8c1b6f1 100644
--- a/src/trx-core/src/rig/state.rs
+++ b/src/trx-core/src/rig/state.rs
@@ -284,6 +284,7 @@ pub struct RigFilterState {
 #[derive(Debug, Clone, Copy, Serialize, Deserialize, PartialEq, Eq)]
 #[serde(rename_all = "lowercase")]
 pub enum WfmDenoiseLevel {
+    Off,
     Auto,
     Low,
     Medium,
diff --git a/src/trx-server/trx-backend/trx-backend-soapysdr/src/demod/wfm.rs b/src/trx-server/trx-backend/trx-backend-soapysdr/src/demod/wfm.rs
index 043587e..3ecdfea 100644
--- a/src/trx-server/trx-backend/trx-backend-soapysdr/src/demod/wfm.rs
+++ b/src/trx-server/trx-backend/trx-backend-soapysdr/src/demod/wfm.rs
@@ -417,8 +417,9 @@ impl StereoDenoise {
             1.0
         };
         let effective_gain = match self.level {
+            WfmDenoiseLevel::Off => 1.0,
             WfmDenoiseLevel::Auto => {
-                let strength = (0.3 + (1.0 - broadband_gain) * 0.7).clamp(0.3, 1.0);
+                let strength = (0.45 + (1.0 - broadband_gain) * 0.55).clamp(0.45, 1.0);
                 1.0 - (1.0 - broadband_gain) * strength
             }
             WfmDenoiseLevel::Low => 1.0 - (1.0 - broadband_gain) * 0.35,
@@ -1063,6 +1064,22 @@ mod tests {
         }
     }
 
+    #[test]
+    fn test_denoise_off_is_bypass() {
+        let mut off = StereoDenoise::new(48_000.0);
+        off.level = WfmDenoiseLevel::Off;
+
+        for &(sum, diff_i, diff_q) in &[
+            (0.1_f32, 0.5_f32, 0.2_f32),
+            (0.0_f32, -0.3_f32, 0.8_f32),
+            (1.0_f32, 1.0_f32, -0.5_f32),
+            (-0.2_f32, 0.001_f32, 0.0_f32),
+        ] {
+            let out = off.process(sum, diff_i, diff_q);
+            assert!((out - diff_i).abs() < 0.000_001);
+        }
+    }
+
     #[test]
     fn test_denoise_per_band_selectivity() {
         use std::f32::consts::TAU;