From 53da1570ec1cc0ed30c81f7bb88a9770177ba1bf Mon Sep 17 00:00:00 2001 From: Stan Grams Date: Sun, 1 Mar 2026 19:43:33 +0100 Subject: [PATCH] [fix](trx-frontend-http): fix bookmark markers invisible on spectrum let-declared bmList is not a window property, so window.bmList in app.js always returned undefined. Change to var so it lands on window; read it via typeof guard in app.js to stay safe if bookmarks.js is absent. Co-Authored-By: Claude Sonnet 4.6 Signed-off-by: Stan Grams --- .../trx-frontend/trx-frontend-http/assets/web/app.js | 10 ++++++---- .../trx-frontend-http/assets/web/plugins/bookmarks.js | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/trx-client/trx-frontend/trx-frontend-http/assets/web/app.js b/src/trx-client/trx-frontend/trx-frontend-http/assets/web/app.js index 72bb545..700d972 100644 --- a/src/trx-client/trx-frontend/trx-frontend-http/assets/web/app.js +++ b/src/trx-client/trx-frontend/trx-frontend-http/assets/web/app.js @@ -4268,8 +4268,9 @@ function drawSpectrum(data) { } // ── Bookmark frequency markers ───────────────────────────────────────────── - const visBookmarks = Array.isArray(window.bmList) - ? window.bmList.filter((bm) => bm.freq_hz >= range.visLoHz && bm.freq_hz <= range.visHiHz) + const _bmListRef = typeof bmList !== "undefined" ? bmList : null; + const visBookmarks = Array.isArray(_bmListRef) + ? _bmListRef.filter((bm) => bm.freq_hz >= range.visLoHz && bm.freq_hz <= range.visHiHz) : []; if (visBookmarks.length > 0) { ctx.save(); @@ -4317,8 +4318,9 @@ function updateBookmarkAxis(range) { const freqAxisEl = document.getElementById("spectrum-freq-axis"); if (!axisEl) return; - const visBookmarks = Array.isArray(window.bmList) - ? window.bmList.filter((bm) => bm.freq_hz >= range.visLoHz && bm.freq_hz <= range.visHiHz) + const _bmRef = typeof bmList !== "undefined" ? bmList : null; + const visBookmarks = Array.isArray(_bmRef) + ? _bmRef.filter((bm) => bm.freq_hz >= range.visLoHz && bm.freq_hz <= range.visHiHz) : []; const hasVisible = visBookmarks.length > 0; diff --git a/src/trx-client/trx-frontend/trx-frontend-http/assets/web/plugins/bookmarks.js b/src/trx-client/trx-frontend/trx-frontend-http/assets/web/plugins/bookmarks.js index 24a738f..2b2ca0c 100644 --- a/src/trx-client/trx-frontend/trx-frontend-http/assets/web/plugins/bookmarks.js +++ b/src/trx-client/trx-frontend/trx-frontend-http/assets/web/plugins/bookmarks.js @@ -1,6 +1,6 @@ // --- Bookmarks Tab --- -let bmList = []; +var bmList = []; let bmEditId = null; function bmFmtFreq(hz) {