sjg/trx-rs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[fix](trx-frontend-http): fix axis bookmark chip positioning after name span addition

Browse Source 
querySelectorAll("span") was picking up the inner .spectrum-bookmark-name
spans added in the previous commit, causing chips[i] to map to the wrong
element during left-position assignment.  Switch to :scope > span to
select only direct-child chip spans.

Also revert axis bar from height:auto (which breaks the CSS transition and
collapses the bar) to height:38px with overflow:visible to accommodate
two-line labels while keeping the open/close animation intact.

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Stanislaw Grams <stanislawgrams@gmail.com>
This commit is contained in:
Stan Grams
2026-03-16 23:37:11 +01:00
parent 4a12d79f92
commit 0f57fb8920
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/trx-client/trx-frontend/trx-frontend-http/assets/web/app.js
+1 -1
View File
@@ -8734,7 +8734,7 @@ function updateBookmarkAxis(range) {
// Always recompute horizontal positions (pan/zoom changes frac every frame). // Always recompute horizontal positions (pan/zoom changes frac every frame).
const axisWidth = axisEl.clientWidth || 0; const axisWidth = axisEl.clientWidth || 0;
const edgePad = 8; const edgePad = 8;
const spans = axisEl.querySelectorAll("span"); const spans = axisEl.querySelectorAll(":scope > span");
visBookmarks.forEach((bm, i) => { visBookmarks.forEach((bm, i) => {
const span = spans[i]; const span = spans[i];
if (!span) return; if (!span) return;
src/trx-client/trx-frontend/trx-frontend-http/assets/web/style.css
+2 -2
View File
@@ -2901,8 +2901,8 @@ button:focus-visible, input:focus-visible, select:focus-visible {
transition: height 80ms ease; transition: height 80ms ease;
} }
#spectrum-bookmark-axis.bm-axis-visible { #spectrum-bookmark-axis.bm-axis-visible {
min-height: 26px; height: 38px;
height: auto; overflow: visible;
} }
.spectrum-bookmark-chip { .spectrum-bookmark-chip {
position: absolute; position: absolute;