[refactor](trx-core): remove SetFirTaps command and fir_taps from state

Drop the SetFirTaps RigCommand variant, remove the set_fir_taps default
trait method from Rig, and remove the fir_taps field from RigFilterState.
Tap count is now derived automatically from audio bandwidth in the DSP
layer rather than being a user-facing control.

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Stanislaw Grams <stanislawgrams@gmail.com>
This commit is contained in:
2026-03-16 23:17:01 +01:00
parent 5aa3d61ce0
commit 0dc6761fa0
4 changed files with 1 additions and 14 deletions
-1
View File
@@ -39,7 +39,6 @@ pub enum RigCommand {
ResetFt2Decoder, ResetFt2Decoder,
ResetWsprDecoder, ResetWsprDecoder,
SetBandwidth(u32), SetBandwidth(u32),
SetFirTaps(u32),
SetSdrGain(f64), SetSdrGain(f64),
SetSdrLnaGain(f64), SetSdrLnaGain(f64),
SetSdrAgc(bool), SetSdrAgc(bool),
@@ -521,7 +521,6 @@ pub fn command_from_rig_command(cmd: RigCommand) -> Box<dyn RigCommandHandler> {
| RigCommand::ResetFt2Decoder | RigCommand::ResetFt2Decoder
| RigCommand::ResetWsprDecoder | RigCommand::ResetWsprDecoder
| RigCommand::SetBandwidth(_) | RigCommand::SetBandwidth(_)
| RigCommand::SetFirTaps(_)
| RigCommand::SetSdrGain(_) | RigCommand::SetSdrGain(_)
| RigCommand::SetSdrLnaGain(_) | RigCommand::SetSdrLnaGain(_)
| RigCommand::SetSdrAgc(_) | RigCommand::SetSdrAgc(_)
+1 -11
View File
@@ -57,7 +57,7 @@ pub struct RigCapabilities {
pub tx_limit: bool, pub tx_limit: bool,
/// Backend supports toggle_vfo. /// Backend supports toggle_vfo.
pub vfo_switch: bool, pub vfo_switch: bool,
/// Backend supports runtime filter adjustment (bandwidth, FIR taps). /// Backend supports runtime filter adjustment (bandwidth).
pub filter_controls: bool, pub filter_controls: bool,
/// Backend returns a meaningful RX signal strength value. /// Backend returns a meaningful RX signal strength value.
pub signal_meter: bool, pub signal_meter: bool,
@@ -160,16 +160,6 @@ pub trait RigCat: Rig + Send {
))) )))
} }
fn set_fir_taps<'a>(
&'a mut self,
_taps: u32,
) -> Pin<Box<dyn Future<Output = DynResult<()>> + Send + 'a>> {
Box::pin(std::future::ready(Err(
Box::new(response::RigError::not_supported("set_fir_taps"))
as Box<dyn std::error::Error + Send + Sync>,
)))
}
fn set_wfm_deemphasis<'a>( fn set_wfm_deemphasis<'a>(
&'a mut self, &'a mut self,
_deemphasis_us: u32, _deemphasis_us: u32,
-1
View File
@@ -308,7 +308,6 @@ impl RigState {
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)] #[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
pub struct RigFilterState { pub struct RigFilterState {
pub bandwidth_hz: u32, pub bandwidth_hz: u32,
pub fir_taps: u32,
pub cw_center_hz: u32, pub cw_center_hz: u32,
#[serde(default, skip_serializing_if = "Option::is_none")] #[serde(default, skip_serializing_if = "Option::is_none")]
pub sdr_gain_db: Option<f64>, pub sdr_gain_db: Option<f64>,