[fix](trx-frontend-http): tidy up the map's filter bar
CI / lint (pull_request) Successful in 2m21s
CI / test (pull_request) Successful in 8m7s
CI / frontend (push) Successful in 2m57s
CI / reuse (push) Successful in 3s
CI / frontend (pull_request) Successful in 3m47s
CI / reuse (pull_request) Successful in 3s
CI / lint (push) Successful in 2m16s
CI / test (push) Successful in 7m19s
CI / lint (pull_request) Successful in 2m21s
CI / test (pull_request) Successful in 8m7s
CI / frontend (push) Successful in 2m57s
CI / reuse (push) Successful in 3s
CI / frontend (pull_request) Successful in 3m47s
CI / reuse (pull_request) Successful in 3s
CI / lint (push) Successful in 2m16s
CI / test (push) Successful in 7m19s
The bar explained itself in prose: "All bands visible by default" sat between the chips and the next group, taking width the bar could not spare and reading as a stray line of text. An "All" chip says the same thing in a chip's width and gives the selection somewhere to be undone. Band chips also came up dimmed at the very moment every band was on the map -- an empty selection is no filter at all, so nothing is dimmed until something is picked. The path toggles drop their "On"/"Off" suffix, which cost most of a row and only repeated what their own highlight already said; state moves to aria-pressed and the tooltip. The rest is alignment. The rule dividing the buttons from the filters is drawn on the button block's edge, and a centred block left it floating as a stub beside a two-row bar; stacked, it lay down the left of a block that sits underneath. The labels sat at their natural widths, so each row's first control started somewhere different, and the two pairs of phase buttons differed in width, so the groups after them missed each other by four pixels. One gutter for every label, one width for both pairs, and the search field moved last where it can take the room the fixed-width groups leave. The map layout test now covers the chips, the divider's height and the rows' shared start. Signed-off-by: Stan Grams <sjg@haxx.space>
This commit was merged in pull request #41.
This commit is contained in:
@@ -2570,7 +2570,10 @@ button.map-qso-card:focus-visible {
|
||||
z-index: 410;
|
||||
display: flex;
|
||||
flex-flow: row nowrap;
|
||||
align-items: center;
|
||||
/* Stretched, not centred: the rule dividing the filters from the buttons is
|
||||
drawn on the button block's edge, and it has to run the height of the bar
|
||||
rather than float beside it as a stub. */
|
||||
align-items: stretch;
|
||||
gap: 0.5rem;
|
||||
width: auto;
|
||||
max-height: calc(100% - 1.4rem);
|
||||
@@ -2590,6 +2593,9 @@ button.map-qso-card:focus-visible {
|
||||
flex: 1 1 auto;
|
||||
flex-flow: row wrap;
|
||||
align-items: center;
|
||||
/* Rows keep their own height when the bar is taller than they are, so the
|
||||
groups stay a bar's two rows rather than drifting apart to fill it. */
|
||||
align-content: center;
|
||||
gap: 0.35rem 0.5rem;
|
||||
min-width: 0;
|
||||
}
|
||||
@@ -2603,6 +2609,9 @@ button.map-qso-card:focus-visible {
|
||||
.map-overlay-actions {
|
||||
display: flex;
|
||||
flex: 0 0 auto;
|
||||
/* The block spans the bar so its divider can; the buttons still sit level
|
||||
with the middle of it. */
|
||||
align-self: stretch;
|
||||
align-items: center;
|
||||
gap: 0.4rem;
|
||||
}
|
||||
@@ -2625,17 +2634,29 @@ button.map-qso-card:focus-visible {
|
||||
padding-right: 0;
|
||||
border-right: 0;
|
||||
}
|
||||
/* The search field takes whatever room the fixed-width groups leave. */
|
||||
/* The search field takes whatever room the fixed-width groups leave, up to a
|
||||
width past which a text box spanning the map reads as a mistake. */
|
||||
.map-overlay-panel .map-filter-grow {
|
||||
flex: 1 1 9rem;
|
||||
max-width: 26rem;
|
||||
}
|
||||
/* One gutter for every label, so whichever group starts a row starts it in the
|
||||
same place: at their natural widths the labels staggered each row's first
|
||||
control by however much the label above it was wider or narrower. */
|
||||
.map-overlay-panel .map-locator-filter-label {
|
||||
min-width: 0;
|
||||
min-width: 3.5rem;
|
||||
padding-top: 0;
|
||||
font-size: 0.72rem;
|
||||
letter-spacing: 0.02em;
|
||||
white-space: nowrap;
|
||||
}
|
||||
/* The two rows of the bar are led by the two pairs of phase buttons, and
|
||||
SOURCE|BAND is wider than TRX|CONTACT: left to their own widths the groups
|
||||
after them missed each other by four pixels. One width for both pairs. */
|
||||
.map-overlay-panel .map-locator-phase-row {
|
||||
flex: 0 0 auto;
|
||||
min-width: 9rem;
|
||||
}
|
||||
.map-overlay-panel .map-history-select {
|
||||
flex: 0 0 auto;
|
||||
width: auto;
|
||||
@@ -3471,6 +3492,23 @@ body.map-fake-fullscreen-active {
|
||||
border-color: color-mix(in srgb, var(--border-light) 68%, transparent);
|
||||
background: color-mix(in srgb, var(--input-bg) 96%, transparent);
|
||||
}
|
||||
/* "All" clears the selection rather than naming a band or a source, so it
|
||||
borrows the phase buttons' look instead of a colour of its own — and says
|
||||
in one chip's width what a line of helper text used to say in the bar. */
|
||||
.map-locator-chip-all {
|
||||
--chip-color: var(--border-light);
|
||||
color: var(--text-muted);
|
||||
}
|
||||
.map-locator-chip-all.is-active {
|
||||
border-color: var(--accent-green);
|
||||
background: color-mix(in srgb, var(--accent-green) 10%, var(--input-bg));
|
||||
color: var(--accent-green);
|
||||
}
|
||||
.map-locator-chip-all .map-locator-chip-text {
|
||||
font-weight: 700;
|
||||
letter-spacing: 0.03em;
|
||||
text-transform: uppercase;
|
||||
}
|
||||
.map-locator-chip-text {
|
||||
font-size: 0.78rem;
|
||||
font-weight: 600;
|
||||
@@ -4196,9 +4234,23 @@ body[data-operator-layout="broadcast"] #cw-bar-overlay {
|
||||
padding-right: 0;
|
||||
border-right: 0;
|
||||
}
|
||||
/* Stacked in a column the panel scrolls, and the search field is no use at
|
||||
the bottom of it: it goes back to the top, where it needs no scrolling. */
|
||||
.map-overlay-panel .map-filter-grow {
|
||||
order: -1;
|
||||
max-width: none;
|
||||
}
|
||||
.map-overlay-actions {
|
||||
justify-content: flex-end;
|
||||
}
|
||||
/* Stacked, the buttons sit under the filters rather than beside them, so the
|
||||
rule that divides them has to lie across the panel, not down its left. */
|
||||
.map-overlay-panel:not(.filters-hidden) .map-overlay-actions {
|
||||
padding-left: 0;
|
||||
padding-top: 0.5rem;
|
||||
border-left: 0;
|
||||
border-top: 1px solid color-mix(in srgb, var(--border-light) 55%, transparent);
|
||||
}
|
||||
.map-overlay-panel .map-paths-hint {
|
||||
display: block;
|
||||
font-size: 0.75rem;
|
||||
|
||||
Reference in New Issue
Block a user